add proper error messages for ingested files

crates/cli/src/lib.rs

@@ -757,10 +757,21 @@ pub fn build(
                     roc_run(&arena, opt_level, triple, args, bytes, expect_metadata)
                 }
                 BuildAndRunIfNoErrors => {
+                    if problems.fatally_errored {
+                        problems.print_to_stdout(total_time);
+                        println!(
+                            ".\n\nCannot run program due to fatal error…\n\n\x1B[36m{}\x1B[39m",
+                            "─".repeat(80)
+                        );
+
+                        // Return a nonzero exit code due to falta problem
+                        return Ok(problems.exit_code());
+                    }
                     debug_assert_eq!(
                         problems.errors, 0,
-                        "if there are errors, they should have been returned as an error variant"
+                        "if there are non-fatal errors, they should have been returned as an error variant"
                     );
+
                     if problems.warnings > 0 {
                         problems.print_to_stdout(total_time);
                         println!(

crates/compiler/mono/src/ir.rs

@@ -4186,9 +4186,11 @@ pub fn with_hole<'a>(
                     Layout::STR,
                     hole,
                 ),
-                _ => unreachable!(
+                _ => {
-                    "All of these cases should be dealt during solve, generating proper errors"
+                    // This will not manifest as a real runtime error and is just returned to have a value here.
-                ),
+                    // The actual type error during solve will be fatal.
+                    runtime_error(env, "Invalid type for ingested file")
+                }
             }
         }
         SingleQuote(_, _, character, _) => {

crates/compiler/solve/src/solve.rs

@@ -1771,7 +1771,7 @@ fn solve(
 
                 state
             }
-            IngestedFile(type_index, _, bytes) => {
+            IngestedFile(type_index, file_path, bytes) => {
                 let actual = either_type_index_to_var(
                     subs,
                     rank,
@@ -1794,34 +1794,37 @@ fn solve(
                 ) {
                     // List U8 always valid.
                     subs.rollback_to(snapshot);
-                    state
+                    return state;
-                } else if let Success { .. } = unify(
+                }
+                subs.rollback_to(snapshot);
+
+                let snapshot = subs.snapshot();
+                // We explicitly match on the last unify to get the type in the case it errors.
+                match unify(
                     &mut UEnv::new(subs),
                     actual,
                     Variable::STR,
                     Mode::EQ,
                     Polarity::OF_VALUE,
                 ) {
-                    // Str only valid if valid utf8.
+                    Success { .. } => {
-                    if std::str::from_utf8(bytes).is_err() {
+                        // Str only valid if valid utf8.
-                        todo!("add type error due to not being a utf8 string");
+                        if let Err(err) = std::str::from_utf8(bytes) {
+                            let problem = TypeError::IngestedFileBadUtf8(file_path.clone(), err);
+                            problems.push(problem);
+                        }
+
+                        subs.rollback_to(snapshot);
+                        state
                     }
+                    Failure(_, actual_type, _, _) => {
+                        subs.rollback_to(snapshot);
 
-                    subs.rollback_to(snapshot);
+                        let problem =
-                    state
+                            TypeError::IngestedFileUnsupportedType(file_path.clone(), actual_type);
-                } else {
+                        problems.push(problem);
-                    // Unexpected type.
+                        state
-                    todo!("Add type error for unsupported ingested file type");
+                    }
-                    // let problem = TypeError::BadExpr(
-                    //     *region,
-                    //     Category::Lookup(*symbol),
-                    //     actual_type,
-                    //     expectation.replace_ref(expected_type),
-                    // );
-
-                    // problems.push(problem);
-                    // subs.rollback_to(snapshot);
-                    // state
                 }
             }
         };

crates/compiler/solve_problem/src/lib.rs

@@ -1,4 +1,6 @@
 //! Provides types to describe problems that can occur during solving.
+use std::{path::Path, str::Utf8Error};
+
 use roc_can::expected::{Expected, PExpected};
 use roc_module::{ident::Lowercase, symbol::Symbol};
 use roc_problem::{can::CycleEntry, Severity};
@@ -29,6 +31,8 @@ pub enum TypeError {
         expected_opaque: Symbol,
         found_opaque: Symbol,
     },
+    IngestedFileBadUtf8(Box<Path>, Utf8Error),
+    IngestedFileUnsupportedType(Box<Path>, ErrorType),
 }
 
 impl TypeError {
@@ -48,6 +52,8 @@ impl TypeError {
             TypeError::Exhaustive(exhtv) => exhtv.severity(),
             TypeError::StructuralSpecialization { .. } => RuntimeError,
             TypeError::WrongSpecialization { .. } => RuntimeError,
+            TypeError::IngestedFileBadUtf8(..) => Fatal,
+            TypeError::IngestedFileUnsupportedType(..) => Fatal,
         }
     }
 }

crates/reporting/src/error/type.rs

@@ -209,6 +209,45 @@ pub fn type_problem<'b>(
                 severity,
             })
         }
+        IngestedFileBadUtf8(file_path, utf8_err) => {
+            let stack = [
+                alloc.concat([
+                    alloc.reflow("Failed to load "),
+                    alloc.text(format!("{:?}", file_path)),
+                    alloc.reflow(" as Str:"),
+                ]),
+                alloc.text(format!("{}", utf8_err)),
+            ];
+            Some(Report {
+                title: "INVALID UTF-8".to_string(),
+                filename,
+                doc: alloc.stack(stack),
+                severity,
+            })
+        }
+        IngestedFileUnsupportedType(file_path, typ) => {
+            let stack = [
+                alloc.concat([
+                    alloc.text(format!("{:?}", file_path)),
+                    alloc.reflow(" is annotated to be a "),
+                    alloc.inline_type_block(error_type_to_doc(alloc, typ)),
+                    alloc.reflow("."),
+                ]),
+                alloc.concat([
+                    alloc.reflow("Ingested files can only be of type "),
+                    alloc.type_str("List U8"),
+                    alloc.reflow(" or "),
+                    alloc.type_str("Str"),
+                    alloc.reflow("."),
+                ]),
+            ];
+            Some(Report {
+                title: "INVALID TYPE FOR INGESTED FILE".to_string(),
+                filename,
+                doc: alloc.stack(stack),
+                severity,
+            })
+        }
     }
 }