Anton-4
74d137cad4
Revert "Merge pull request #7267 from joshuawarner32/fuzzing-bugs-2"
...
This reverts commit 364249a29d
, reversing
changes made to 0e550a7f68
.
2024-11-30 18:43:16 +01:00
Joshua Warner
ed62bcc15a
Fix a bunch of parser/formatter bugs found in fuzzing
...
Notably:
* Unified how parens are formatted between (1) when we have a ParensAround, and (2) when we've decided an Apply needs to have parens
* Made unary minus require the be indented to the same level as any other expression continuation. (it used to accidentally have rules meant for binary operators applied)
* Don't apply extra indent to the backpassing continuation in the case that the call does itself require indentation
* Make `try@foo` correctly parse as `try @foo`, so that formatting doesn't change the tree when it adds that space
* Detect more cases where we need to outdent trailing e.g. {} blocks in applies
* Approximately a bagillion other things, 90% of which I added tests for, and none of which affected the formatting of examples or builtins
2024-11-29 16:25:59 -08:00
Agus Zubiaga
1dc9dd0a90
Merge branch 'main' into specialize-exprs
2024-11-27 11:35:14 -03:00
Joshua Warner
b4fdb0a4c2
Make dbg parse strictly as an Apply
...
This is important in order to fix some formatting bugs found in fuzzing
2024-11-24 14:15:29 -08:00
Agus Zubiaga
2e96aca0fd
Merge branch 'main' into specialize-exprs
2024-11-23 01:48:51 -03:00
JRI98
a332acd7bf
Remove unused malformed related variants
2024-11-14 10:23:06 +00:00
Luke Boswell
4b4ab7bc0c
Merge remote-tracking branch 'remote/main' into record-suffix-warn-tweaks
2024-11-13 07:29:31 +11:00
Luke Boswell
04ab86fa8e
clippy fix
2024-11-11 22:12:07 +11:00
Luke Boswell
24a90007c5
use only unix style slashes in problem reports
2024-11-11 21:42:11 +11:00
Luke Boswell
8a566dc339
WIP
2024-11-11 10:22:58 +11:00
Agus Zubiaga
ecc5fa57dd
Check record field suffixes in annotations
2024-11-09 02:06:05 -03:00
Agus Zubiaga
12c735644f
Do not warn about pure functions in suffixed record literal fields
...
Records fields that allow effectful functions, should also accept
pure functions.
2024-11-09 01:05:06 -03:00
Agus Zubiaga
bc0cfef128
Restore UNNCESSARY DEFINITION errors for top-level defs
...
Non-top-level defs are already covered
2024-11-07 18:54:25 -03:00
Agus Zubiaga
a4296ca19d
Improve wording in pattern suffix errors
2024-11-07 18:54:25 -03:00
Agus Zubiaga
1e835bbb17
Fix 'right-hand side' typo in errors
2024-11-07 18:54:25 -03:00
Agus Zubiaga
935d460236
Use plural 'effects' in FxInTopLevel error
2024-11-07 18:54:25 -03:00
Agus Zubiaga
c9f001b041
Allow ignored defs with an effectful RHS
2024-11-07 18:54:22 -03:00
Agus Zubiaga
175a2b5683
Add hint about forgetting to call a function
2024-11-07 18:54:21 -03:00
Agus Zubiaga
cfc4be5254
Treat untyped suffixed functions as effectful
2024-11-07 18:54:21 -03:00
Agus Zubiaga
e75b1cf7a0
Check suffixes of all pattern identifiers
2024-11-07 18:54:20 -03:00
Agus Zubiaga
a31a35100b
Report suffixed pure function in literal record field
2024-11-07 18:54:20 -03:00
Agus Zubiaga
215de707fa
Report unsuffixed record literal field with effectful function
2024-11-07 18:54:20 -03:00
Agus Zubiaga
89a918cebe
Fix unifying pure with flex vars
2024-11-07 18:54:19 -03:00
Agus Zubiaga
6533e9084d
Add fx to ErrorType
2024-11-07 18:54:19 -03:00
Agus Zubiaga
9a5a5c3462
Remove irrelevant todos
2024-11-07 18:54:18 -03:00
Agus Zubiaga
6adc6d9168
Report ignored statement results
2024-11-07 18:54:18 -03:00
Agus Zubiaga
b01771c5ae
Show effectful function name in mismatches
2024-11-07 18:54:18 -03:00
Agus Zubiaga
f666dba67d
Report effectful top-level exprs
2024-11-07 18:54:17 -03:00
Agus Zubiaga
b62665e49e
Report effectful statement in pure function
2024-11-07 18:54:17 -03:00
Agus Zubiaga
fd2493ee51
Report effect call in pure function
2024-11-07 18:54:17 -03:00
Agus Zubiaga
d22b2a79f5
Suffixed pure function warning
2024-11-07 18:54:17 -03:00
Agus Zubiaga
1da8af390b
Unsuffixed effectul function warning
2024-11-07 18:54:16 -03:00
Agus Zubiaga
69e026f8bb
Leftover statement warning for pure statements
2024-11-07 18:54:16 -03:00
Agus Zubiaga
6e6382ab23
Canonicalize and constrain statement expr in purity inference mode
2024-11-07 18:54:15 -03:00
Agus Zubiaga
2cce5ad023
Allow unsuffixed statements in parser
...
Moves the "STATEMENT AFTER EXPRESSION" error from the parser to canonicalization.
We'll later use this to allow this case in effectful functions.
2024-11-07 18:54:14 -03:00
Agus Zubiaga
7af05cc6c9
Constrain function annotation fx to body
2024-11-07 18:54:13 -03:00
Agus Zubiaga
a7634f3c5f
Improve unhandled errors in to_syntax_report
2024-11-06 12:54:17 -03:00
Agus Zubiaga
3722cb9596
Improve unhandled BadInput syntax errors
2024-11-06 12:47:43 -03:00
Agus Zubiaga
7bd15292ac
Improve unhandled packages syntax errors
2024-11-06 12:46:17 -03:00
Agus Zubiaga
4a6955d096
Improve unhandled requires syntax errors
2024-11-06 12:45:18 -03:00
Agus Zubiaga
f2f0db198b
Improve unhandled imports syntax errors
2024-11-06 12:42:36 -03:00
Agus Zubiaga
168af093f2
Improve unhandled exposes syntax errors
2024-11-06 12:42:07 -03:00
Agus Zubiaga
20ce5aef04
Improve unhandled provides syntax errors
2024-11-06 12:41:11 -03:00
Agus Zubiaga
0e97bfa29f
Improve unhandled type syntax errors
2024-11-06 12:40:07 -03:00
Agus Zubiaga
9c742caf9b
Improve unhandled pattern errors
2024-11-06 12:36:52 -03:00
Agus Zubiaga
160dbee943
Nicer message for unhandled expr errors
2024-11-06 12:15:38 -03:00
Agus Zubiaga
b9a693c077
Replace wildcard todos in parser reporting with explicit matches
...
This will helps us remember to add good errors when making
syntax changes.
2024-11-06 11:12:21 -03:00
Agus Zubiaga
f4c8492c1c
Report return syntax errors
2024-11-06 10:50:32 -03:00
Luke Boswell
c00db6da37
Merge remote-tracking branch 'remote/main' into rebuild-platform
2024-11-04 13:57:51 +11:00
Sam Mohr
66cc96edbb
Address PR comments from @ayazhafiz
2024-10-29 15:58:35 -07:00