mirror of
https://github.com/astral-sh/ruff.git
synced 2025-09-28 04:45:01 +00:00
6a1fa4778f
## Summary This commit adds some additional error checking to the parser such that assignments that are invalid syntax are rejected. This covers the obvious cases like `5 = 3` and some not so obvious cases like `x + y = 42`. This does add an additional recursive call to the parser for the cases handling assignments. I had initially been concerned about doing this, but `set_context` is already doing recursion during assignments, so I didn't feel as though this was changing any fundamental performance characteristics of the parser. (Also, in practice, I would expect any such recursion here to be quite shallow since the recursion is done on the target of an assignment. Such things are rarely nested much in practice.) Fixes #6895 ## Test Plan I've added unit tests covering every case that is detected as invalid on an `Expr`. |
||
|---|---|---|
| .. | ||
| lexer | ||
| snapshots | ||
| context.rs | ||
| function.rs | ||
| invalid.rs | ||
| lexer.rs | ||
| lib.rs | ||
| parser.rs | ||
| python.lalrpop | ||
| python.rs | ||
| soft_keywords.rs | ||
| string.rs | ||
| token.rs | ||
| typing.rs | ||