mirror of
https://github.com/astral-sh/ruff.git
synced 2025-09-27 04:19:18 +00:00
399 lines
17 KiB
Rust
399 lines
17 KiB
Rust
use std::borrow::Cow;
|
|
|
|
use ruff_formatter::{format_args, write, FormatContext};
|
|
use ruff_python_ast::str::Quote;
|
|
use ruff_python_ast::str_prefix::{
|
|
AnyStringPrefix, ByteStringPrefix, FStringPrefix, StringLiteralPrefix,
|
|
};
|
|
use ruff_python_ast::{AnyStringFlags, FStringElement, StringFlags, StringLike, StringLikePart};
|
|
use ruff_source_file::LineRanges;
|
|
use ruff_text_size::{Ranged, TextRange};
|
|
|
|
use crate::comments::{leading_comments, trailing_comments};
|
|
use crate::expression::parentheses::in_parentheses_only_soft_line_break_or_space;
|
|
use crate::other::f_string::{FStringContext, FStringLayout, FormatFString};
|
|
use crate::other::f_string_element::FormatFStringExpressionElement;
|
|
use crate::other::string_literal::StringLiteralKind;
|
|
use crate::prelude::*;
|
|
use crate::preview::{
|
|
is_f_string_formatting_enabled, is_join_implicit_concatenated_string_enabled,
|
|
};
|
|
use crate::string::docstring::needs_chaperone_space;
|
|
use crate::string::normalize::{
|
|
is_fstring_with_quoted_debug_expression,
|
|
is_fstring_with_triple_quoted_literal_expression_containing_quotes, QuoteMetadata,
|
|
};
|
|
use crate::string::{normalize_string, StringLikeExtensions, StringNormalizer, StringQuotes};
|
|
|
|
/// Formats any implicitly concatenated string. This could be any valid combination
|
|
/// of string, bytes or f-string literals.
|
|
pub(crate) struct FormatImplicitConcatenatedString<'a> {
|
|
string: StringLike<'a>,
|
|
}
|
|
|
|
impl<'a> FormatImplicitConcatenatedString<'a> {
|
|
pub(crate) fn new(string: impl Into<StringLike<'a>>) -> Self {
|
|
Self {
|
|
string: string.into(),
|
|
}
|
|
}
|
|
}
|
|
|
|
impl Format<PyFormatContext<'_>> for FormatImplicitConcatenatedString<'_> {
|
|
fn fmt(&self, f: &mut PyFormatter) -> FormatResult<()> {
|
|
let expanded = FormatImplicitConcatenatedStringExpanded::new(self.string);
|
|
|
|
// If the string can be joined, try joining the implicit concatenated string into a single string
|
|
// if it fits on the line. Otherwise, parenthesize the string parts and format each part on its
|
|
// own line.
|
|
if let Some(flat) = FormatImplicitConcatenatedStringFlat::new(self.string, f.context()) {
|
|
write!(
|
|
f,
|
|
[if_group_fits_on_line(&flat), if_group_breaks(&expanded)]
|
|
)
|
|
} else {
|
|
expanded.fmt(f)
|
|
}
|
|
}
|
|
}
|
|
|
|
/// Formats an implicit concatenated string where parts are separated by a space or line break.
|
|
pub(crate) struct FormatImplicitConcatenatedStringExpanded<'a> {
|
|
string: StringLike<'a>,
|
|
}
|
|
|
|
impl<'a> FormatImplicitConcatenatedStringExpanded<'a> {
|
|
pub(crate) fn new(string: StringLike<'a>) -> Self {
|
|
assert!(string.is_implicit_concatenated());
|
|
|
|
Self { string }
|
|
}
|
|
}
|
|
|
|
impl Format<PyFormatContext<'_>> for FormatImplicitConcatenatedStringExpanded<'_> {
|
|
fn fmt(&self, f: &mut Formatter<PyFormatContext<'_>>) -> FormatResult<()> {
|
|
let comments = f.context().comments().clone();
|
|
let quoting = self.string.quoting(f.context().source());
|
|
|
|
let join_implicit_concatenated_string_enabled =
|
|
is_join_implicit_concatenated_string_enabled(f.context());
|
|
let mut joiner = f.join_with(in_parentheses_only_soft_line_break_or_space());
|
|
|
|
for part in self.string.parts() {
|
|
let format_part = format_with(|f: &mut PyFormatter| match part {
|
|
StringLikePart::String(part) => {
|
|
let kind = if self.string.is_fstring() {
|
|
#[allow(deprecated)]
|
|
StringLiteralKind::InImplicitlyConcatenatedFString(quoting)
|
|
} else {
|
|
StringLiteralKind::String
|
|
};
|
|
|
|
part.format().with_options(kind).fmt(f)
|
|
}
|
|
StringLikePart::Bytes(bytes_literal) => bytes_literal.format().fmt(f),
|
|
StringLikePart::FString(part) => FormatFString::new(part, quoting).fmt(f),
|
|
});
|
|
|
|
let part_comments = comments.leading_dangling_trailing(&part);
|
|
joiner.entry(&format_args![
|
|
(!join_implicit_concatenated_string_enabled).then_some(line_suffix_boundary()),
|
|
leading_comments(part_comments.leading),
|
|
format_part,
|
|
trailing_comments(part_comments.trailing)
|
|
]);
|
|
}
|
|
|
|
joiner.finish()
|
|
}
|
|
}
|
|
|
|
/// Formats an implicit concatenated string where parts are joined into a single string if possible.
|
|
pub(crate) struct FormatImplicitConcatenatedStringFlat<'a> {
|
|
string: StringLike<'a>,
|
|
flags: AnyStringFlags,
|
|
docstring: bool,
|
|
}
|
|
|
|
impl<'a> FormatImplicitConcatenatedStringFlat<'a> {
|
|
/// Creates a new formatter. Returns `None` if the string can't be merged into a single string.
|
|
pub(crate) fn new(string: StringLike<'a>, context: &PyFormatContext) -> Option<Self> {
|
|
fn merge_flags(string: StringLike, context: &PyFormatContext) -> Option<AnyStringFlags> {
|
|
if !is_join_implicit_concatenated_string_enabled(context) {
|
|
return None;
|
|
}
|
|
|
|
// Multiline strings can never fit on a single line.
|
|
if !string.is_fstring() && string.is_multiline(context.source()) {
|
|
return None;
|
|
}
|
|
|
|
let first_part = string.parts().next()?;
|
|
|
|
// The string is either a regular string, f-string, or bytes string.
|
|
let normalizer = StringNormalizer::from_context(context);
|
|
|
|
// Some if a part requires preserving its quotes.
|
|
let mut preserve_quotes_requirement: Option<Quote> = None;
|
|
|
|
// Early exit if it's known that this string can't be joined
|
|
for part in string.parts() {
|
|
// Similar to Black, don't collapse triple quoted and raw strings.
|
|
// We could technically join strings that are raw-strings and use the same quotes but lets not do this for now.
|
|
// Joining triple quoted strings is more complicated because an
|
|
// implicit concatenated string could become a docstring (if it's the first string in a block).
|
|
// That means the joined string formatting would have to call into
|
|
// the docstring formatting or otherwise guarantee that the output
|
|
// won't change on a second run.
|
|
if part.flags().is_triple_quoted() || part.flags().is_raw_string() {
|
|
return None;
|
|
}
|
|
|
|
// For now, preserve comments documenting a specific part over possibly
|
|
// collapsing onto a single line. Collapsing could result in pragma comments
|
|
// now covering more code.
|
|
if context.comments().leading_trailing(&part).next().is_some() {
|
|
return None;
|
|
}
|
|
|
|
if let StringLikePart::FString(fstring) = part {
|
|
if fstring.elements.iter().any(|element| match element {
|
|
// Same as for other literals. Multiline literals can't fit on a single line.
|
|
FStringElement::Literal(literal) => {
|
|
context.source().contains_line_break(literal.range())
|
|
}
|
|
FStringElement::Expression(expression) => {
|
|
if is_f_string_formatting_enabled(context) {
|
|
// Expressions containing comments can't be joined.
|
|
context.comments().contains_comments(expression.into())
|
|
} else {
|
|
// Multiline f-string expressions can't be joined if the f-string formatting is disabled because
|
|
// the string gets inserted in verbatim preserving the newlines.
|
|
context.source().contains_line_break(expression.range())
|
|
}
|
|
}
|
|
}) {
|
|
return None;
|
|
}
|
|
|
|
// Avoid invalid syntax for pre Python 312:
|
|
// * When joining parts that have debug expressions with quotes: `f"{10 + len('bar')=}" f'{10 + len("bar")=}'
|
|
// * When joining parts that contain triple quoted strings with quotes: `f"{'''test ' '''}" f'{"""other " """}'`
|
|
if !context.options().target_version().supports_pep_701() {
|
|
if is_fstring_with_quoted_debug_expression(fstring, context)
|
|
|| is_fstring_with_triple_quoted_literal_expression_containing_quotes(
|
|
fstring, context,
|
|
)
|
|
{
|
|
if preserve_quotes_requirement
|
|
.is_some_and(|quote| quote != part.flags().quote_style())
|
|
{
|
|
return None;
|
|
}
|
|
preserve_quotes_requirement = Some(part.flags().quote_style());
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
// The string is either a regular string, f-string, or bytes string.
|
|
let mut merged_quotes: Option<QuoteMetadata> = None;
|
|
|
|
// Only preserve the string type but disregard the `u` and `r` prefixes.
|
|
// * It's not necessary to preserve the `r` prefix because Ruff doesn't support joining raw strings (we shouldn't get here).
|
|
// * It's not necessary to preserve the `u` prefix because Ruff discards the `u` prefix (it's meaningless in Python 3+)
|
|
let prefix = match string {
|
|
StringLike::String(_) => AnyStringPrefix::Regular(StringLiteralPrefix::Empty),
|
|
StringLike::Bytes(_) => AnyStringPrefix::Bytes(ByteStringPrefix::Regular),
|
|
StringLike::FString(_) => AnyStringPrefix::Format(FStringPrefix::Regular),
|
|
};
|
|
|
|
// Only determining the preferred quote for the first string is sufficient
|
|
// because we don't support joining triple quoted strings with non triple quoted strings.
|
|
let quote = if let Ok(preferred_quote) =
|
|
Quote::try_from(normalizer.preferred_quote_style(first_part))
|
|
{
|
|
for part in string.parts() {
|
|
let part_quote_metadata =
|
|
QuoteMetadata::from_part(part, context, preferred_quote);
|
|
|
|
if let Some(merged) = merged_quotes.as_mut() {
|
|
*merged = part_quote_metadata.merge(merged)?;
|
|
} else {
|
|
merged_quotes = Some(part_quote_metadata);
|
|
}
|
|
}
|
|
|
|
merged_quotes?.choose(preferred_quote)
|
|
} else {
|
|
// Use the quotes of the first part if the quotes should be preserved.
|
|
first_part.flags().quote_style()
|
|
};
|
|
|
|
Some(AnyStringFlags::new(prefix, quote, false))
|
|
}
|
|
|
|
if !string.is_implicit_concatenated() {
|
|
return None;
|
|
}
|
|
|
|
Some(Self {
|
|
flags: merge_flags(string, context)?,
|
|
string,
|
|
docstring: false,
|
|
})
|
|
}
|
|
|
|
pub(crate) fn set_docstring(&mut self, is_docstring: bool) {
|
|
self.docstring = is_docstring;
|
|
}
|
|
|
|
pub(crate) fn string(&self) -> StringLike<'a> {
|
|
self.string
|
|
}
|
|
}
|
|
|
|
impl Format<PyFormatContext<'_>> for FormatImplicitConcatenatedStringFlat<'_> {
|
|
fn fmt(&self, f: &mut Formatter<PyFormatContext<'_>>) -> FormatResult<()> {
|
|
// Merges all string parts into a single string.
|
|
let quotes = StringQuotes::from(self.flags);
|
|
|
|
write!(f, [self.flags.prefix(), quotes])?;
|
|
|
|
let mut parts = self.string.parts().peekable();
|
|
|
|
// Trim implicit concatenated strings in docstring positions.
|
|
// Skip over any trailing parts that are all whitespace.
|
|
// Leading parts are handled as part of the formatting loop below.
|
|
if self.docstring {
|
|
for part in self.string.parts().rev() {
|
|
assert!(part.is_string_literal());
|
|
|
|
if f.context().source()[part.content_range()].trim().is_empty() {
|
|
// Don't format the part.
|
|
parts.next_back();
|
|
} else {
|
|
break;
|
|
}
|
|
}
|
|
}
|
|
|
|
let mut first_non_empty = self.docstring;
|
|
|
|
while let Some(part) = parts.next() {
|
|
match part {
|
|
StringLikePart::String(_) | StringLikePart::Bytes(_) => {
|
|
FormatLiteralContent {
|
|
range: part.content_range(),
|
|
flags: self.flags,
|
|
is_fstring: false,
|
|
trim_start: first_non_empty && self.docstring,
|
|
trim_end: self.docstring && parts.peek().is_none(),
|
|
}
|
|
.fmt(f)?;
|
|
|
|
if first_non_empty {
|
|
first_non_empty = f.context().source()[part.content_range()]
|
|
.trim_start()
|
|
.is_empty();
|
|
}
|
|
}
|
|
|
|
StringLikePart::FString(f_string) => {
|
|
if is_f_string_formatting_enabled(f.context()) {
|
|
for element in &f_string.elements {
|
|
match element {
|
|
FStringElement::Literal(literal) => {
|
|
FormatLiteralContent {
|
|
range: literal.range(),
|
|
flags: self.flags,
|
|
is_fstring: true,
|
|
trim_end: false,
|
|
trim_start: false,
|
|
}
|
|
.fmt(f)?;
|
|
}
|
|
// Formatting the expression here and in the expanded version is safe **only**
|
|
// because we assert that the f-string never contains any comments.
|
|
FStringElement::Expression(expression) => {
|
|
let context = FStringContext::new(
|
|
self.flags,
|
|
FStringLayout::from_f_string(
|
|
f_string,
|
|
f.context().source(),
|
|
),
|
|
);
|
|
|
|
FormatFStringExpressionElement::new(expression, context)
|
|
.fmt(f)?;
|
|
}
|
|
}
|
|
}
|
|
} else {
|
|
FormatLiteralContent {
|
|
range: part.content_range(),
|
|
flags: self.flags,
|
|
is_fstring: true,
|
|
trim_end: false,
|
|
trim_start: false,
|
|
}
|
|
.fmt(f)?;
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
quotes.fmt(f)
|
|
}
|
|
}
|
|
|
|
struct FormatLiteralContent {
|
|
range: TextRange,
|
|
flags: AnyStringFlags,
|
|
is_fstring: bool,
|
|
trim_start: bool,
|
|
trim_end: bool,
|
|
}
|
|
|
|
impl Format<PyFormatContext<'_>> for FormatLiteralContent {
|
|
fn fmt(&self, f: &mut PyFormatter) -> FormatResult<()> {
|
|
let content = &f.context().source()[self.range];
|
|
let mut normalized = normalize_string(
|
|
content,
|
|
0,
|
|
self.flags,
|
|
self.flags.is_f_string() && !self.is_fstring,
|
|
// TODO: Remove the argument from `normalize_string` when promoting the `is_f_string_formatting_enabled` preview style.
|
|
self.flags.is_f_string() && !is_f_string_formatting_enabled(f.context()),
|
|
is_f_string_formatting_enabled(f.context()),
|
|
);
|
|
|
|
// Trim the start and end of the string if it's the first or last part of a docstring.
|
|
// This is rare, so don't bother with optimizing to use `Cow`.
|
|
if self.trim_start {
|
|
let trimmed = normalized.trim_start();
|
|
if trimmed.len() < normalized.len() {
|
|
normalized = trimmed.to_string().into();
|
|
}
|
|
}
|
|
|
|
if self.trim_end {
|
|
let trimmed = normalized.trim_end();
|
|
if trimmed.len() < normalized.len() {
|
|
normalized = trimmed.to_string().into();
|
|
}
|
|
}
|
|
|
|
if !normalized.is_empty() {
|
|
match &normalized {
|
|
Cow::Borrowed(_) => source_text_slice(self.range).fmt(f)?,
|
|
Cow::Owned(normalized) => text(normalized).fmt(f)?,
|
|
}
|
|
|
|
if self.trim_end && needs_chaperone_space(self.flags, &normalized, f.context()) {
|
|
space().fmt(f)?;
|
|
}
|
|
}
|
|
Ok(())
|
|
}
|
|
}
|