language-servers/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-09-29 13:25:17 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3
ruff/crates/red_knot_python_semantic/resources/mdtest/diagnostics/unpacking.md
David Peter e345307260
[red-knot] Fix diagnostic range for non-iterable unpacking assignments (#15994) 
## Summary

I noticed that the diagnostic range in specific unpacking assignments is
wrong. For this example

```py
a, b = 1
```

we previously got (see first commit):

```
error: lint:not-iterable
 --> /src/mdtest_snippet.py:1:1
  |
1 | a, b = 1
  | ^^^^ Object of type `Literal[1]` is not iterable
  |
```

and with this change, we get:

```
error: lint:not-iterable
 --> /src/mdtest_snippet.py:1:8
  |
1 | a, b = 1
  |        ^ Object of type `Literal[1]` is not iterable
  |
```

## Test Plan

New snapshot tests.
2025-02-06 15:36:22 +01:00

293 B
Raw Blame History

Unpacking

Right hand side not iterable

a, b = 1  # error: [not-iterable]

Too many values to unpack

a, b = (1, 2, 3)  # error: [invalid-assignment]

Too few values to unpack

a, b = (1,)  # error: [invalid-assignment]