Commit graph

34140 commits

Author SHA1 Message Date
Chayim Refael Friedman
150bb4a00f
Merge pull request #19617 from ChayimFriedman2/more-actual
internal: Make `HirFileId`, `EditionedFileId` and macro files Salsa struct
2025-04-19 19:21:53 +00:00
Chayim Refael Friedman
c58ddafe90 Make HirFileId, EditionedFileId and macro files Salsa struct
And make more queries non-interned.

Also flip the default for queries, now the default is to not intern and to intern a query you need to say `invoke_interned`.
2025-04-19 22:10:52 +03:00
Lukas Wirth
6568e8f12d
Merge pull request #19628 from jyn514/warn-bad-config
don't ignore config values that fail to parse
2025-04-19 14:20:05 +00:00
jyn
46ce4746e6 don't ignore config values that fail to parse
previously, these would just silently be ignored. now they give a
warning such as:
```
invalid config values: /completion/snippets/custom: invalid type: null, expected a map; /cargo/extraEnv: invalid type: null, expected a string;
```
2025-04-19 10:08:05 -04:00
Lukas Wirth
a09a5502c3
Merge pull request #19613 from ChayimFriedman2/subst
fix: Fix a panic when a trait method in an impl declares a lifetime parameter not in the trait declaration
2025-04-18 18:51:14 +00:00
Laurențiu Nicola
16745db3f7
Merge pull request #19618 from lnicola/pgo-revision
internal: Support specific revisions for PGO
2025-04-18 10:10:09 +00:00
Laurențiu Nicola
0ba49a3777 Support specific revisions for pgo 2025-04-18 12:58:52 +03:00
Chayim Refael Friedman
02ade79631
Merge pull request #19619 from ChayimFriedman2/sort-notable
fix: Sort notable traits in hover
2025-04-18 09:56:45 +00:00
Chayim Refael Friedman
41227f01d2 Sort notable traits in hover
Previously it was ordered by what accidentally happened to be the crate graph order, which isn't sensible, plus it caused changes when any change was done to salsa IDs.
2025-04-18 12:45:22 +03:00
Lukas Wirth
32052e5054
Merge pull request #19616 from ChayimFriedman2/transparent-diags
internal: Make hir-ty non-diagnostic queries transparent
2025-04-18 08:53:53 +00:00
Chayim Refael Friedman
5e3a914dc2 Make hir-ty non-diagnostic queries transparent
That is, all queries that have a `with_diagnostic` variant.

Them being tracked was (maybe) needed before #19462, because back then diagnostics could refer `AstId`s (for macro types), but now they are no longer needed.
2025-04-18 07:04:13 +03:00
Chayim Refael Friedman
346f2d7559 Fix a panic when a trait method in an impl declares a lifetime parameter not in the trait declaration
Shuffle the code a bit.
2025-04-18 06:28:17 +03:00
Laurențiu Nicola
ed737b545e
Merge pull request #19614 from lnicola/macos-14-arm64
internal: Build MacOS AArch64 releases on that platform
2025-04-17 08:25:14 +00:00
Lukas Wirth
71d23b9a6b
Merge pull request #19612 from ChayimFriedman2/parent-generics
fix: Fix a bug with predicate lowering of associated items
2025-04-17 08:17:26 +00:00
Laurențiu Nicola
e6ebfed17e Build MacOS AArch64 releases on that platform 2025-04-17 11:13:35 +03:00
Laurențiu Nicola
672c11e8b1
Merge pull request #19611 from zamazan4ik/patch-1
Use PGO on macOS x64 and arm64 builds
2025-04-17 07:44:52 +00:00
Chayim Refael Friedman
e1962d2e22 Fix a bug with predicate lowering of associated items
The essence of the bug is that bounds on `impl Trait` got lowered with incorrect bound vars, as if we were lowering the parent.
2025-04-17 00:19:54 +03:00
Alexander Zaitsev
77e7b33a51
Use PGO on macOS x64 and arm64 builds
- realted to https://github.com/rust-lang/rust-analyzer/issues/9412#issuecomment-2810772246
2025-04-16 23:57:59 +03:00
Chayim Refael Friedman
0a8f808ebc
Merge pull request #19605 from ChayimFriedman2/fix-sig
minor: Fix signature of libc memory usage function on Linux
2025-04-16 14:08:37 +00:00
Chayim Refael Friedman
1cb9b1cb38 Fix signature of libc memory usage function on Linux
A soundness issue!
2025-04-16 16:56:45 +03:00
Lukas Wirth
1748a84888
Merge pull request #19589 from roife/fix-issue-19138
fix: highlighting for tail expr in labelled blocks
2025-04-16 11:20:05 +00:00
roifewu
cfc28f3148 feat: highlight tail expr when cursor is on label 2025-04-16 19:08:44 +08:00
Lukas Wirth
ea273513ed
Merge pull request #19591 from snprajwal/fix-make-macro
fix: use `ast::TokenTree` in `make::expr_macro`
2025-04-16 07:47:25 +00:00
Lukas Wirth
4bef2bf192
Merge pull request #19590 from roife/fix-issue-19540
feat: add `pub(crate) mod` option for unlinked files
2025-04-16 07:43:43 +00:00
Lukas Wirth
5242ea6ca7
Merge pull request #19597 from Kobzol/arm-ci
Build aarch64 builds on CI with PGO
2025-04-16 07:43:34 +00:00
Prajwal S N
243854211c
fix: use ast::TokenTree in make::expr_macro
Signed-off-by: Prajwal S N <prajwalnadig21@gmail.com>
2025-04-16 13:06:42 +05:30
Lukas Wirth
d5a3d14cac
Merge pull request #19596 from roife/sig-help-info
feat: enhance signature help to display generic parameters for callables and default values for generic args
2025-04-16 07:27:21 +00:00
Lukas Wirth
50d6f18349
Merge pull request #19588 from Hmikihiro/ext_func_module
fix: `Extract into` function include inline variable in fmt macro
2025-04-16 07:15:15 +00:00
Lukas Wirth
94f984f908
Merge pull request #19587 from MatrixFrog/patch-1
Remove incorrect doc comment
2025-04-16 07:12:35 +00:00
Lukas Wirth
b75b78b9d9
Merge pull request #19600 from Kobzol/pin-proc-macro-rustc
Pin rustc used for the `proc-macro-src` CI job
2025-04-16 07:09:24 +00:00
Jakub Beránek
263092085d
Pin rustc used for the proc-macro-src CI job 2025-04-16 08:58:25 +02:00
Jakub Beránek
16526809fe Perform PGO for aarch64 builds 2025-04-15 22:03:16 +02:00
Laurențiu Nicola
bdd0491668
Merge pull request #19595 from Kobzol/ci-linux-pgo
Use PGO on Linux x64 builds
2025-04-15 18:51:24 +00:00
roifewu
727d4b184d feat: enhance signature help to display generic parameters for callables and default values for generic args 2025-04-16 02:41:08 +08:00
Jakub Beránek
78043e9211 Use PGO on Linux x64 builds 2025-04-15 20:32:23 +02:00
Laurențiu Nicola
f766d1403e
Merge pull request #19585 from Kobzol/pgo-windows
Allow training PGO on a custom crate and enable it Windows on CI
2025-04-15 18:10:59 +00:00
Laurențiu Nicola
0a60ce6c8e
Merge pull request #19586 from Kobzol/manylinux-instead-of-zigbuild
Use a Docker container instead of Zig for building with old(er) glibc on x64 Linux
2025-04-15 14:10:13 +00:00
Jakub Beránek
4633fbf146
Use manylinux Docker container instead of zigbuild for x64 Linux
This gets us glibc 2.28 without using `cargo zigbuild`, which is not compatible with PGO.
2025-04-15 15:42:40 +02:00
Jakub Beránek
e12d15d119
Use -q to silence RA output 2025-04-15 12:46:56 +02:00
Jakub Beránek
07307f5654
Run PGO for Windows on CI 2025-04-15 12:18:09 +02:00
Jakub Beránek
813ea83e5f
Allow passing a specific crate for PGO training 2025-04-15 11:25:16 +02:00
Jakub Beránek
136bf7f734
Fix llvm-profdata extension on non Linux OSes 2025-04-15 11:19:37 +02:00
roifewu
7fde3fcd2e feat: Add pub(crate) mod option for unlinked files 2025-04-15 13:12:03 +08:00
roifewu
78503f2d1f feat: highlight tail expression in labeled block 2025-04-15 12:58:38 +08:00
Hayashi Mikihiro
28e34c8d33 fix: `Extract into function include inline variable in fmt macro
Signed-off-by: Hayashi Mikihiro <34ttrweoewiwe28@gmail.com>
2025-04-15 11:19:50 +09:00
Tyler Breisacher
f9716e4782
Remove incorrect doc comment 2025-04-14 19:05:13 -07:00
Lukas Wirth
b8cf608cfe
Merge pull request #19583 from Kobzol/revert-19582-ci-pgo
Do not perform PGO on Linux CI
2025-04-14 15:47:06 +00:00
Jakub Beránek
4c86214f47
Do not enable PGO in combination with zigbuild 2025-04-14 17:35:50 +02:00
Lukas Wirth
7fc29a99ef
Merge pull request #19568 from snprajwal/destructure-struct-editor
refactor: editor for `destructure_struct_binding`
2025-04-14 15:35:00 +00:00
Lukas Wirth
aded72f8e6
Merge pull request #19572 from snprajwal/expand-rest-pattern
refactor: migrate `expand_rest_pattern` to editor
2025-04-14 14:50:08 +00:00