Merge pull request #4300 from ei-grad/robust-model-settings-override
Some checks failed
pre-commit / pre-commit (push) Has been cancelled

fix: Remove existing model settings before adding new ones
This commit is contained in:
paul-gauthier 2025-07-01 11:12:13 -03:00 committed by GitHub
commit 3db4d378eb
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -1052,12 +1052,10 @@ def register_models(model_settings_fnames):
for model_settings_dict in model_settings_list:
model_settings = ModelSettings(**model_settings_dict)
existing_model_settings = next(
(ms for ms in MODEL_SETTINGS if ms.name == model_settings.name), None
)
if existing_model_settings:
MODEL_SETTINGS.remove(existing_model_settings)
# Remove all existing settings for this model name
MODEL_SETTINGS[:] = [ms for ms in MODEL_SETTINGS if ms.name != model_settings.name]
# Add the new settings
MODEL_SETTINGS.append(model_settings)
except Exception as e:
raise Exception(f"Error loading model settings from {model_settings_fname}: {e}")