mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-31 05:58:33 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

Fixes issue #19506: Use a memoryview to avoid a data copy when piping data

Browse source 
to stdin within subprocess.Popen.communicate.  5-10% less cpu usage.
This commit is contained in:
Gregory P. Smith 2013-12-07 19:14:59 -08:00
commit 5ca129b8f0
2 changed files with 8 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Lib/subprocess.py
View file

@ -1562,6 +1562,9 @@ class Popen(object):
self._save_input(input)
if self._input:
input_view = memoryview(self._input)
with _PopenSelector() as selector:
if self.stdin and input:
selector.register(self.stdin, selectors.EVENT_WRITE)
@ -1583,8 +1586,8 @@ class Popen(object):
for key, events in ready:
if key.fileobj is self.stdin:
chunk = self._input[self._input_offset :
self._input_offset + _PIPE_BUF]
chunk = input_view[self._input_offset :
self._input_offset + _PIPE_BUF]
try:
self._input_offset += os.write(key.fd, chunk)
except OSError as e: