Issue 19572: More silently skipped tests explicitly skipped.

This commit is contained in:
Zachary Ware 2013-12-08 00:20:35 -06:00
parent 774f909489
commit 9fe6d86709
34 changed files with 122 additions and 134 deletions

View file

@ -57,7 +57,7 @@ class AbstractMemoryTests:
def test_setitem_readonly(self):
if not self.ro_type:
return
self.skipTest("no read-only type to test")
b = self.ro_type(self._source)
oldrefcount = sys.getrefcount(b)
m = self._view(b)
@ -71,7 +71,7 @@ class AbstractMemoryTests:
def test_setitem_writable(self):
if not self.rw_type:
return
self.skipTest("no writable type to test")
tp = self.rw_type
b = self.rw_type(self._source)
oldrefcount = sys.getrefcount(b)
@ -189,13 +189,13 @@ class AbstractMemoryTests:
def test_attributes_readonly(self):
if not self.ro_type:
return
self.skipTest("no read-only type to test")
m = self.check_attributes_with_type(self.ro_type)
self.assertEqual(m.readonly, True)
def test_attributes_writable(self):
if not self.rw_type:
return
self.skipTest("no writable type to test")
m = self.check_attributes_with_type(self.rw_type)
self.assertEqual(m.readonly, False)
@ -301,7 +301,7 @@ class AbstractMemoryTests:
# buffer as writable causing a segfault if using mmap
tp = self.ro_type
if tp is None:
return
self.skipTest("no read-only type to test")
b = tp(self._source)
m = self._view(b)
i = io.BytesIO(b'ZZZZ')
@ -370,12 +370,12 @@ class BaseArrayMemoryTests(AbstractMemoryTests):
itemsize = array.array('i').itemsize
format = 'i'
@unittest.skip('XXX test should be adapted for non-byte buffers')
def test_getbuffer(self):
# XXX Test should be adapted for non-byte buffers
pass
@unittest.skip('XXX NotImplementedError: tolist() only supports byte views')
def test_tolist(self):
# XXX NotImplementedError: tolist() only supports byte views
pass