mirrors/datafusion-sqlparse
1
0
Fork 0
mirror of https://github.com/apache/datafusion-sqlparser-rs.git synced 2025-07-07 17:04:59 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Support DOUBLE data types with precision for Mysql (#1611)

Browse source
This commit is contained in:
artorias1024 2024-12-20 01:11:39 +08:00 • committed by GitHub
parent eae5629fb8
commit c973df35d6
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 21 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/ast/data_type.rs
View file

@ -254,7 +254,7 @@ pub enum DataType {
/// [postgresql]: https://www.postgresql.org/docs/15/datatype.html
Float8,
/// Double
Double,
Double(ExactNumberInfo),
/// Double PRECISION e.g. [standard], [postgresql]
///
/// [standard]: https://jakewheat.github.io/sql-overview/sql-2016-foundation-grammar.html#approximate-numeric-type
@ -508,7 +508,7 @@ impl fmt::Display for DataType {
DataType::Float4 => write!(f, "FLOAT4"),
DataType::Float32 => write!(f, "Float32"),
DataType::Float64 => write!(f, "FLOAT64"),
DataType::Double => write!(f, "DOUBLE"),
DataType::Double(info) => write!(f, "DOUBLE{info}"),
DataType::Float8 => write!(f, "FLOAT8"),
DataType::DoublePrecision => write!(f, "DOUBLE PRECISION"),
DataType::Bool => write!(f, "BOOL"),

4
src/parser/mod.rs
View file

@ -8115,7 +8115,9 @@ impl<'a> Parser<'a> {
if self.parse_keyword(Keyword::PRECISION) {
Ok(DataType::DoublePrecision)
} else {
Ok(DataType::Double)
Ok(DataType::Double(
self.parse_exact_number_optional_precision_scale()?,
))
}
}
Keyword::TINYINT => {

12
tests/sqlparser_common.rs
View file

@ -3009,7 +3009,7 @@ fn parse_create_table() {
},
ColumnDef {
name: "lat".into(),
data_type: DataType::Double,
data_type: DataType::Double(ExactNumberInfo::None),
collation: None,
options: vec![ColumnOptionDef {
name: None,
@ -3018,7 +3018,7 @@ fn parse_create_table() {
},
ColumnDef {
name: "lng".into(),
data_type: DataType::Double,
data_type: DataType::Double(ExactNumberInfo::None),
collation: None,
options: vec![],
},
@ -3198,7 +3198,7 @@ fn parse_create_table_with_constraint_characteristics() {
},
ColumnDef {
name: "lat".into(),
data_type: DataType::Double,
data_type: DataType::Double(ExactNumberInfo::None),
collation: None,
options: vec![ColumnOptionDef {
name: None,
@ -3207,7 +3207,7 @@ fn parse_create_table_with_constraint_characteristics() {
},
ColumnDef {
name: "lng".into(),
data_type: DataType::Double,
data_type: DataType::Double(ExactNumberInfo::None),
collation: None,
options: vec![],
},
@ -3838,7 +3838,7 @@ fn parse_create_external_table() {
},
ColumnDef {
name: "lat".into(),
data_type: DataType::Double,
data_type: DataType::Double(ExactNumberInfo::None),
collation: None,
options: vec![ColumnOptionDef {
name: None,
@ -3847,7 +3847,7 @@ fn parse_create_external_table() {
},
ColumnDef {
name: "lng".into(),
data_type: DataType::Double,
data_type: DataType::Double(ExactNumberInfo::None),
collation: None,
options: vec![],
},

10
tests/sqlparser_mysql.rs
View file

@ -3022,3 +3022,13 @@ fn parse_longblob_type() {
fn parse_begin_without_transaction() {
mysql().verified_stmt("BEGIN");
}
#[test]
fn parse_double_precision() {
mysql().verified_stmt("CREATE TABLE foo (bar DOUBLE)");
mysql().verified_stmt("CREATE TABLE foo (bar DOUBLE(11,0))");
mysql().one_statement_parses_to(
"CREATE TABLE foo (bar DOUBLE(11, 0))",
"CREATE TABLE foo (bar DOUBLE(11,0))",
);
}