Commit graph

1143 commits

Author SHA1 Message Date
Pavel Minaev
c5feeea05b Fix ptvsd.server command line parsing for filenames on Python 2. 2019-08-12 14:44:44 -07:00
Pavel Minaev
a698340985 Add .cmd script to clean various Python-related build and run artifacts in the repo - .pyc, .pyo, .pyd, __pycache__. 2019-08-12 14:14:39 -07:00
Karthik Nadig
0f6a9bb1d6
Update tests to use python debug adapter (#1660)
* Initial fix for launch

* Minor fixes

* Succesful launch tests

* More launch test fixes

* Some bit of cleanup

* Fix linter

* More cleanup

* Attach using import

*  Fix circular importing

* Support attach via command line

* Backchannel and Other test fixes

* Linter fix

* Python path fix in test

* Fix lint after rebase

* Support exitCode in tests

* More fixes after rebase

* Fix expected exit code

* Remove changes to MessageDict __call__

* Remove hold subprocess event
2019-08-12 13:53:24 -07:00
Pavel Minaev
981b1d1559 Fix #1648: Messaging does not allow reverse requests
Separate message parsing and message handling into separate threads.

Remove nested message handling in request handlers via `yield`, since it is incompatible with the new split model, and replace it with NO_RESPONSE and Request.respond() to defer responses until later.

Change Message.cant_handle() and Message.isnt_valid() to respond to the request and return the exception, instead of raising it, to accommodate NO_RESPONSE scenarios where a failure needs to be reported later.

Fix #1678: Do not rely on "processId" being returned by "runInTerminal" request

Extract debuggee PID from the "process" event sent by the debug server.

Fix #1679: "exited" event sometimes reports "exitCode": null

Report it as -1 if it cannot be retrieved from the debuggee process.

Fix #1680: Fatal errors in message loop do not fail fast

os._exit() immediately if a fatal error occurs in message parsing or message handling background threads.
2019-08-11 19:46:54 -07:00
Pavel Minaev
7256e99b52 Use a separate exception type NoMoreMessages to indicate end-of-stream for JSON messaging, to avoid leaking EOFError from disk I/O or from another stream not being properly reported as errors. 2019-08-11 19:46:54 -07:00
Karthik Nadig
b61c05a3e5
Set don't trace patterns from the debug server (#1676) 2019-08-09 15:55:35 -07:00
Karthik Nadig
84cac1499e
Cancel wait for attach if IDE is disconnected (#1657)
* Cancel wait for attach if IDE is disconnected

* Remove cancel wait wrapper

* cleanup
2019-08-05 16:17:58 -07:00
Karthik Nadig
ebf4629ca8
Add --log-dir switch to adapter (#1653)
* Add --log-dir switch to adapter

* Address comments
2019-08-02 19:30:40 -07:00
Karthik Nadig
e093c86fba
#1449, #1498, partially #1448 (#1651)
* Remove wrapper and in-proc support code

* Fixing up multiproc patching

* Address comments

* Import cleanup

* More cleanup

* Remove loopback fast path

* Disable IDE disconnect unpause-ing

* Add missing file to do not trace
2019-08-02 13:08:07 -07:00
Pavel Minaev
0ea50467aa Fix #1488: Handling launch (spawn ptvsd) (#1647)
Fix #1605: Debuggee process lifetime management
Mitigate #1637: log.exception() doesn't capture the full stack

Handle "launch" request, parse and validate the debug configuration, and spawn the debuggee process with debug server.

Track debuggee process and its subprocesses, and kill them as needed.

Refactor Singleton and ThreadSafeSingleton to allow for easier synchronization between IDE and server message handlers without excessive locking.

Fix various corner cases and race conditions in disconnect scenarios.

Make log.exception() log the calling stack, not just the exception stack.

Add JSON property validation to MessageDict.

Add --log-stderr switch to the server to enable full logging to stderr.

Add --cls switch to the adapter to reset terminal before logging anything (for convenience when debugging it).

Add some printf-debugging helpers.
2019-07-31 13:05:06 -07:00
Karthik Nadig
4581c52de7
Add initialize request (#1618) 2019-07-23 13:29:25 -07:00
Pavel Minaev
527a17cdce Fix #1614: Test run times out on Python 2.7 (#1615)
Close the watchdog message channel from the test process side after "stop" command is sent and acknowledged.
2019-07-22 22:21:01 -07:00
Pavel Minaev
bb7375da31 Fix test_launcher on Python 2.7. 2019-07-22 17:01:53 -07:00
Pavel Minaev
061f5e9721 Fix linting issues. 2019-07-22 17:01:53 -07:00
Pavel Minaev
e0ee0bde53 Add CODEOWNERS. 2019-07-22 17:01:53 -07:00
Pavel Minaev
6727665878 Fix #1612: Parse and expose DAP capabilities
Add ptvsd.adapter.contract module as a single access point for capabilities and other immutable IDE and server metadata.

Change the semantics of Channels.server() to enable checks for disconnected server.

Fix "disconnect" and "terminate" handling when not connected to debug server.

Do best-effort handling of "ptvsd_systemInfo" if not connected to debug server.
2019-07-22 17:01:53 -07:00
Pavel Minaev
b08e8e2233 Fix Message.is_response() 2019-07-22 17:01:53 -07:00
Pavel Minaev
e87025d664 Provide backwards compatibility with "from ptvsd.__main__ import main". 2019-07-22 17:01:53 -07:00
Pavel Minaev
b2d5414d0e Reformat code. 2019-07-22 17:01:53 -07:00
Pavel Minaev
5c6f3779d3 Add Message.request() helper for synchronous requests that wait for response.
Add Message.is_response() helper.

Add Message.payload helper accessor that redirects to Message.arguments or Message.body as appropriate.
2019-07-22 17:01:53 -07:00
Pavel Minaev
ffbbf64832 Add docstring to ptvsd.adapter.options 2019-07-22 17:01:53 -07:00
Pavel Minaev
7973e5beac Fix sys.path patching when running ptvsd without -m. 2019-07-22 17:01:53 -07:00
Karthik Nadig
6aa8134125
Add launcher script that handles wait-on-* feature (#1609)
* Add launcher script that handles wait-on-* feature

* Address comments

* Improve argument parsing

* Add tests

* Address test comments
2019-07-19 13:51:51 -07:00
Karthik Nadig
d50e63eaa7
Move debugger attached state into pydevd (#1610)
* Move debugger attached state into pydevd

* Fix linter

* Fix tests
2019-07-19 13:50:38 -07:00
Pavel Minaev
907351522d Fix race condition in test_attach. 2019-07-18 10:13:02 -07:00
Pavel Minaev
73d29fa55b Work around #1603 in tests.
Add long_tmpdir fixture, that always supplies a long rather than short path name on Windows.

Use long_tmpdir in the implementation of @pyfile, and in all tests that use tmpdir to generate code.
2019-07-18 10:13:02 -07:00
Pavel Minaev
3cb99794d9 Log connection errors in wait_until_port_is_listening() test helper.
Do not reuse socket in wait_until_port_is_listening() to avoid issues on macOS.
2019-07-18 10:13:02 -07:00
Pavel Minaev
4aec028c32 Improve multiprocess and reattach scenario handling in debug.Session.
Use unbuffered pipes for subprocesses on all Python versions.

Make test watchdog more lenient with respect to process ID reuse - warn, but don't fail.
2019-07-18 10:13:02 -07:00
Pavel Minaev
045fb03888 Detect and log watchdog errors in the tests process.
Do not indent messages that are arrays in the log, to reduce watchdog log verbosity.
2019-07-18 10:13:02 -07:00
Pavel Minaev
32e95c434f Fix #1585 for test_add_and_remove_breakpoint 2019-07-18 10:13:02 -07:00
Pavel Minaev
becee1f697 Properly handle partial writes in JsonIOStream. 2019-07-18 10:13:02 -07:00
Pavel Minaev
1da62fa7b2 Fix JsonIOStream.read_json not correctly detecting EOF over pipes. 2019-07-18 10:13:02 -07:00
Pavel Minaev
a5312fdc8a Fix #1585 for test_log_point 2019-07-18 10:13:02 -07:00
Pavel Minaev
40f1ded82c Explicitly stop the test watchdog at exit. 2019-07-18 10:13:02 -07:00
Pavel Minaev
c04d394a73 Make test_attach parameters clearer. 2019-07-18 10:13:02 -07:00
Pavel Minaev
2963bf98fe Skip test_reattach (#1594) 2019-07-18 10:13:02 -07:00
Pavel Minaev
44ca8fa3fc Fix #1555: Child process watchdog for tests
Implement per-test-runner out-of-process watchdog for processes spawned by tests.

Add file logging for tests and watchdog.

Improve stdio capture in debug.Session when test fails.

Remove redundant logging in debug.Session.
2019-07-18 10:13:02 -07:00
Pavel Minaev
5dcca5fce0 Fix wrapping in timeline logs, and increase the repr length limit accordingly. 2019-07-18 10:13:02 -07:00
Pavel Minaev
4cd1d4163f Fix #1585: Output tests fail sporadically
Wait on a breakpoint before checking output.

Add temp workaround for #1574: Flask tests fail with "no such option: --wait" on windows py27

Pin Flask version to last known good one in tests/requirements.txt.

Other fixes and improvements:

Make start_method mandatory for debug.Session to avoid problems with tests forgetting to specify it.

Add debug_me.scratchpad to enable async communication between test code and debuggee.

Improve debug.Session logging.

Improve test_attach.
2019-07-18 10:13:02 -07:00
Pavel Minaev
edd5753d7e Further improve timeline logging:
Reformat various timeline log entries to improve readability.

Add pretty-printing of composite expectations, to match pretty-printed JSON.

Avoid redundant repetitions of messages when explaining how occurrences matched expectations.
2019-07-18 10:13:02 -07:00
Pavel Minaev
22f25c8d04 Fix timeline logging on Python 2. 2019-07-18 10:13:02 -07:00
Pavel Minaev
c511e98b02 Remove prints in tests outside of the code being debugged - use logging instead. 2019-07-18 10:13:02 -07:00
Pavel Minaev
8d189c8e91 Improve timeline logging for DAP messages:
Show only the metadata necessary to identify the message to reduce verbosiy.

Use JSON representation for easy matching against message logs.
2019-07-18 10:13:02 -07:00
Karthik Nadig
60434f405d
Minor fixes to get debugger working (#1597) 2019-07-15 19:45:28 -07:00
Karthik Nadig
d24a39de31
Create client socket and connect to debug server (#1595)
* Create client socket and connect to debug server

* Addressing comments

* Some minor fixes
2019-07-15 14:35:47 -07:00
Pavel Minaev
c03206972d Fix remaining tests to reflect the debug adapter refactoring changes.
Fix Flask and Django multiprocess tests.

Fix test logs not being captured by pytest.

Fix "import debug_me" check improperly applied in tests where it is unnecessary.

Fix some clarifying patterns not respecting the underlying pattern.

Add pattern helpers for strings: starting_with, ending_with, containing.

Move DAP test helpers to a separate module, and add a helper for frames.

Add support for line markers when setting breakpoints and matching frames.

Assorted test fixes around handling of Unicode and paths.
2019-07-11 16:19:06 -07:00
Pavel Minaev
746bda561e Test fixes. 2019-07-09 12:01:13 -07:00
Pavel Minaev
af768a7611 Blacken more modules. 2019-07-08 12:03:31 -07:00
Pavel Minaev
42bbc0946d Test fixes. 2019-07-08 12:03:31 -07:00
Pavel Minaev
0f76b660ed Fix and refactor debugServer mode for ptvsd.adapter. (#1567)
Add launch.json for convenient testing of ptvsd.adapter.

Various minor fixes.
2019-07-08 11:38:25 -07:00