Commit graph

1129 commits

Author SHA1 Message Date
Pavel Minaev
e0ee0bde53 Add CODEOWNERS. 2019-07-22 17:01:53 -07:00
Pavel Minaev
6727665878 Fix #1612: Parse and expose DAP capabilities
Add ptvsd.adapter.contract module as a single access point for capabilities and other immutable IDE and server metadata.

Change the semantics of Channels.server() to enable checks for disconnected server.

Fix "disconnect" and "terminate" handling when not connected to debug server.

Do best-effort handling of "ptvsd_systemInfo" if not connected to debug server.
2019-07-22 17:01:53 -07:00
Pavel Minaev
b08e8e2233 Fix Message.is_response() 2019-07-22 17:01:53 -07:00
Pavel Minaev
e87025d664 Provide backwards compatibility with "from ptvsd.__main__ import main". 2019-07-22 17:01:53 -07:00
Pavel Minaev
b2d5414d0e Reformat code. 2019-07-22 17:01:53 -07:00
Pavel Minaev
5c6f3779d3 Add Message.request() helper for synchronous requests that wait for response.
Add Message.is_response() helper.

Add Message.payload helper accessor that redirects to Message.arguments or Message.body as appropriate.
2019-07-22 17:01:53 -07:00
Pavel Minaev
ffbbf64832 Add docstring to ptvsd.adapter.options 2019-07-22 17:01:53 -07:00
Pavel Minaev
7973e5beac Fix sys.path patching when running ptvsd without -m. 2019-07-22 17:01:53 -07:00
Karthik Nadig
6aa8134125
Add launcher script that handles wait-on-* feature (#1609)
* Add launcher script that handles wait-on-* feature

* Address comments

* Improve argument parsing

* Add tests

* Address test comments
2019-07-19 13:51:51 -07:00
Karthik Nadig
d50e63eaa7
Move debugger attached state into pydevd (#1610)
* Move debugger attached state into pydevd

* Fix linter

* Fix tests
2019-07-19 13:50:38 -07:00
Pavel Minaev
907351522d Fix race condition in test_attach. 2019-07-18 10:13:02 -07:00
Pavel Minaev
73d29fa55b Work around #1603 in tests.
Add long_tmpdir fixture, that always supplies a long rather than short path name on Windows.

Use long_tmpdir in the implementation of @pyfile, and in all tests that use tmpdir to generate code.
2019-07-18 10:13:02 -07:00
Pavel Minaev
3cb99794d9 Log connection errors in wait_until_port_is_listening() test helper.
Do not reuse socket in wait_until_port_is_listening() to avoid issues on macOS.
2019-07-18 10:13:02 -07:00
Pavel Minaev
4aec028c32 Improve multiprocess and reattach scenario handling in debug.Session.
Use unbuffered pipes for subprocesses on all Python versions.

Make test watchdog more lenient with respect to process ID reuse - warn, but don't fail.
2019-07-18 10:13:02 -07:00
Pavel Minaev
045fb03888 Detect and log watchdog errors in the tests process.
Do not indent messages that are arrays in the log, to reduce watchdog log verbosity.
2019-07-18 10:13:02 -07:00
Pavel Minaev
32e95c434f Fix #1585 for test_add_and_remove_breakpoint 2019-07-18 10:13:02 -07:00
Pavel Minaev
becee1f697 Properly handle partial writes in JsonIOStream. 2019-07-18 10:13:02 -07:00
Pavel Minaev
1da62fa7b2 Fix JsonIOStream.read_json not correctly detecting EOF over pipes. 2019-07-18 10:13:02 -07:00
Pavel Minaev
a5312fdc8a Fix #1585 for test_log_point 2019-07-18 10:13:02 -07:00
Pavel Minaev
40f1ded82c Explicitly stop the test watchdog at exit. 2019-07-18 10:13:02 -07:00
Pavel Minaev
c04d394a73 Make test_attach parameters clearer. 2019-07-18 10:13:02 -07:00
Pavel Minaev
2963bf98fe Skip test_reattach (#1594) 2019-07-18 10:13:02 -07:00
Pavel Minaev
44ca8fa3fc Fix #1555: Child process watchdog for tests
Implement per-test-runner out-of-process watchdog for processes spawned by tests.

Add file logging for tests and watchdog.

Improve stdio capture in debug.Session when test fails.

Remove redundant logging in debug.Session.
2019-07-18 10:13:02 -07:00
Pavel Minaev
5dcca5fce0 Fix wrapping in timeline logs, and increase the repr length limit accordingly. 2019-07-18 10:13:02 -07:00
Pavel Minaev
4cd1d4163f Fix #1585: Output tests fail sporadically
Wait on a breakpoint before checking output.

Add temp workaround for #1574: Flask tests fail with "no such option: --wait" on windows py27

Pin Flask version to last known good one in tests/requirements.txt.

Other fixes and improvements:

Make start_method mandatory for debug.Session to avoid problems with tests forgetting to specify it.

Add debug_me.scratchpad to enable async communication between test code and debuggee.

Improve debug.Session logging.

Improve test_attach.
2019-07-18 10:13:02 -07:00
Pavel Minaev
edd5753d7e Further improve timeline logging:
Reformat various timeline log entries to improve readability.

Add pretty-printing of composite expectations, to match pretty-printed JSON.

Avoid redundant repetitions of messages when explaining how occurrences matched expectations.
2019-07-18 10:13:02 -07:00
Pavel Minaev
22f25c8d04 Fix timeline logging on Python 2. 2019-07-18 10:13:02 -07:00
Pavel Minaev
c511e98b02 Remove prints in tests outside of the code being debugged - use logging instead. 2019-07-18 10:13:02 -07:00
Pavel Minaev
8d189c8e91 Improve timeline logging for DAP messages:
Show only the metadata necessary to identify the message to reduce verbosiy.

Use JSON representation for easy matching against message logs.
2019-07-18 10:13:02 -07:00
Karthik Nadig
60434f405d
Minor fixes to get debugger working (#1597) 2019-07-15 19:45:28 -07:00
Karthik Nadig
d24a39de31
Create client socket and connect to debug server (#1595)
* Create client socket and connect to debug server

* Addressing comments

* Some minor fixes
2019-07-15 14:35:47 -07:00
Pavel Minaev
c03206972d Fix remaining tests to reflect the debug adapter refactoring changes.
Fix Flask and Django multiprocess tests.

Fix test logs not being captured by pytest.

Fix "import debug_me" check improperly applied in tests where it is unnecessary.

Fix some clarifying patterns not respecting the underlying pattern.

Add pattern helpers for strings: starting_with, ending_with, containing.

Move DAP test helpers to a separate module, and add a helper for frames.

Add support for line markers when setting breakpoints and matching frames.

Assorted test fixes around handling of Unicode and paths.
2019-07-11 16:19:06 -07:00
Pavel Minaev
746bda561e Test fixes. 2019-07-09 12:01:13 -07:00
Pavel Minaev
af768a7611 Blacken more modules. 2019-07-08 12:03:31 -07:00
Pavel Minaev
42bbc0946d Test fixes. 2019-07-08 12:03:31 -07:00
Pavel Minaev
0f76b660ed Fix and refactor debugServer mode for ptvsd.adapter. (#1567)
Add launch.json for convenient testing of ptvsd.adapter.

Various minor fixes.
2019-07-08 11:38:25 -07:00
Karthik Nadig
e14ae2c0f9
Add option to connect to adapter via port from IDE (#1562)
* Add option to connect to adapter via port from IDE

* Addressing comments.
2019-07-03 20:11:36 -07:00
Pavel Minaev
773ecb5643 Fix #1552: attach_socket_import tests hang waiting for "process" event
Preload codecs used by ptvsd and pydevd to avoid deadlocks when calling wait_for_attach()  while importing a module on Python 2.
2019-07-02 22:38:37 -07:00
Pavel Minaev
82b62b77b5 Fix #1551: Backchannel failures in tests
Fix various bugs around handling of disconnect in JsonIOStream and JsonMessageChannel.

Fix handling of DAP "terminated" event in debug.Session.

Add --ptvsd-logs and --pydevd-logs switches to pytest.

Improve message logging to fully capture the raw message data in the logs if deserialization fails.

Log all debuggee environment variables in debug.Session, and improve log readability.
2019-07-02 17:05:51 -07:00
Karthik Nadig
1e6d2269dd
Replace wait_for_thread_stopped with wait_for_stop (#1550)
* Replace wait_for_thread_stopped with wait_for_stop

* Switch flask tests to use flask server

* Assert linter

* Use marked lines

* Fix stack logging in tests

* Prevent black from formating some debug code

* Simplify flask tests

* Replace send_request(continue) with send_continue

* fix typo
2019-07-01 14:38:07 -07:00
Karthik Nadig
833011d901
Custom pydevd event to support InputRequested (#1546) 2019-07-01 10:24:51 -07:00
Karthik Nadig
8d75d6d819
Test refactoring migrated to new api (#1544)
* Update ANY to some

* Refactor breakpoint lines in tests

* Replace old import and emable debug with debug_me

* Remove unused code

* Fix some linter issues

* Change from some.such_that to some.str.such_that

* Linting with black
2019-06-28 16:27:38 -07:00
Pavel Minaev
f71f0a5b0a Tests refactoring. (#1543) 2019-06-28 10:13:00 -07:00
Karthik Nadig
b29c459ff8
Migrate bunch of requests, Fix #1491, Fix #1492, Fix #1493 (#1517)
* Migrate bunch of requests, Fix #1491, #1492, #1493

* Use new api

* Tweak some requests

* fix linter

* Address comments.

* linter fixes
2019-06-21 16:44:17 -07:00
Pavel Minaev
5b10a74698 Blacken newly written code. 2019-06-19 01:06:57 -07:00
Pavel Minaev
b9e02b9e79
Fix and improve comments and docstrings 2019-06-19 00:58:30 -07:00
Pavel Minaev
106f9a8852
Fix outdated comment 2019-06-19 00:13:21 -07:00
Pavel Minaev
1e6ba092d3 Refactor messaging:
- better propagation of messages and errors
- implicit error handling for invalid messages
- fix various issues related to disconnecting

Fix messaging tests.

Separate formatter from logging for reuse.

Add more Python 2/3 compatibility helpers.
2019-06-18 18:08:49 -07:00
Pavel Minaev
336d8609a7 Fix and refactor message propagation API. 2019-06-12 13:24:08 -07:00
Pavel Minaev
0471474afe Remove unnecessary import. 2019-06-10 14:58:54 -07:00