Jacob Walls
1eac2659a1
Fixed #36807 -- Fixed form field alignment under <fieldset> in the admin.
...
Linters / flake8 (push) Has been cancelled
Linters / isort (push) Has been cancelled
Linters / black (push) Has been cancelled
Linters / zizmor (push) Has been cancelled
Tests / Windows, SQLite, Python 3.14 (push) Has been cancelled
Tests / JavaScript tests (push) Has been cancelled
Docs / spelling (push) Has been cancelled
Docs / blacken-docs (push) Has been cancelled
Docs / lint-docs (push) Has been cancelled
It isn't safe to set display: flex on <fieldset>, because on Safari this
interferes with display: block on child divs.
Thanks Paulo Coutinho for the report and Antoliny for the review.
Regression in 4187da258f .
2025-12-22 21:04:01 -05:00
Nilesh Kumar Pahari
968f3f9637
Refs #36806 -- Removed unnecessary null=True from GeneratedField in test models.
...
Test coverage is preserved because the tests only verify that generated
fields can produce NULL values when the source field is nullable.
This addresses system check warnings in the test suite after
6025eab3c5 .
2025-12-22 20:38:55 -05:00
guro-Ishiguro
84bae9c22a
Fixed #36818 -- Ensured SQLite connection before accessing max_query_params.
...
Regression in 358fd21c47 .
2025-12-22 20:33:13 -05:00
Jacob Walls
0def695e3c
Refs #27100 -- Removed obsolete message from tutorial and migrations topic.
...
The project state is cached, so when it was calculated in #27100
during the pre-migrate stage, it was no longer calculated on forward
migrations. Backward migrations still calculate it.
2025-12-22 20:24:08 -05:00
ankan0503
bddcefb00f
Fixed #36305 -- Added documentation indentation guidelines to contributing docs.
Docs / spelling (push) Waiting to run
Docs / blacken-docs (push) Waiting to run
Docs / lint-docs (push) Waiting to run
Linters / flake8 (push) Waiting to run
Linters / isort (push) Waiting to run
Linters / black (push) Waiting to run
Linters / zizmor (push) Waiting to run
Tests / Windows, SQLite, Python 3.14 (push) Waiting to run
Tests / JavaScript tests (push) Waiting to run
2025-12-22 14:42:00 -05:00
ankan0503
cc8ee496a5
Refs #36305 -- Fixed indentation in checks and middleware documentation.
2025-12-22 14:42:00 -05:00
JaeHyuck Sa
163d92c1d6
Fixed #36787 -- Fixed crash in In lookups with mixed expressions and strings.
...
Signed-off-by: JaeHyuck Sa <wogur981208@gmail.com>
2025-12-22 14:25:45 -05:00
Youngkwang Yang
95394443bf
Fixed #36786 -- Fixed XML serialization of None values in natural keys.
...
None values in natural keys were incorrectly serialized as the string
"None", causing deserialization to fail for fields like UUIDField.
2025-12-22 14:21:01 -05:00
Clifford Gama
6ee8e9d56c
Fixed #36508 -- Interpreted __iexact=None on KeyTransforms as __exact=None.
...
Thanks Jacob Walls for the report.
2025-12-22 14:20:07 -05:00
Clifford Gama
9cc5c87ffb
Replaced per-object create() calls with bulk_create in tests/model_fields/test_jsonfield.py
2025-12-22 14:20:07 -05:00
Skyiesac
d0d85cd165
Fixed #36376 -- Fixed --no-color for command help in Python 3.14+.
...
https://github.com/python/cpython/pull/136809 made `color` default to
True in ArgumentParser.
2025-12-22 14:02:21 -05:00
Nilesh Kumar Pahari
6025eab3c5
Fixed #36806 -- Added system check for null kwarg in GeneratedField.
...
Docs / spelling (push) Waiting to run
Docs / blacken-docs (push) Waiting to run
Docs / lint-docs (push) Waiting to run
Linters / flake8 (push) Waiting to run
Linters / isort (push) Waiting to run
Linters / black (push) Waiting to run
Linters / zizmor (push) Waiting to run
Tests / Windows, SQLite, Python 3.14 (push) Waiting to run
Tests / JavaScript tests (push) Waiting to run
The null argument has no effect on GeneratedField since the nullability
of the column depends on the database and expression used.
2025-12-22 09:41:41 -05:00
사재혁
afaa527c43
Fixed typo in django/db/backends/base/schema.py comment.
...
Signed-off-by: JaeHyuck Sa <wogur981208@gmail.com>
2025-12-22 12:05:25 +01:00
Nilesh Kumar Pahari
e49e14fd90
Fixed #36618 -- Corrected error message in BaseForm.add_error().
...
Tests / Windows, SQLite, Python 3.14 (push) Has been cancelled
Tests / JavaScript tests (push) Has been cancelled
Docs / spelling (push) Has been cancelled
Docs / blacken-docs (push) Has been cancelled
Linters / zizmor (push) Has been cancelled
Docs / lint-docs (push) Has been cancelled
Linters / flake8 (push) Has been cancelled
Linters / isort (push) Has been cancelled
Linters / black (push) Has been cancelled
The error message now correctly states that the error argument
is a dictionary.
2025-12-19 15:10:12 -05:00
Jacob Walls
5a851bdbfc
Refs #27380 -- Added release note for raw argument to m2m_changed signal.
2025-12-19 14:02:28 -05:00
Johanan Oppong Amoateng
33a0a6f033
Fixed #36791 -- Made MigrationAutodetector recreate through table when m2m target model changes.
...
Co-Authored-By: Jacob Walls <38668450+jacobtylerwalls@users.noreply.github.com>
Co-Authored-By: Clifford Gama <cliffygamy@gmail.com>
2025-12-19 14:01:37 -05:00
eevelweezel
948f1bf5a1
Fixed #36590 -- Made async cache methods use specialized sync versions if available.
...
Thanks Simon Charette, Sarah Boyce, and Jacob Walls for reviews.
2025-12-19 13:02:22 -05:00
Krishnaprasad MG
7a2f35b1b7
Fixed #36487 -- Fixed logger error message with partial callbacks.
2025-12-19 12:58:29 -05:00
JaeHyuck Sa
60fecd1d44
Fixed #36781 -- Added Granian to deployment documentation.
...
Docs / spelling (push) Waiting to run
Docs / blacken-docs (push) Waiting to run
Docs / lint-docs (push) Waiting to run
Linters / flake8 (push) Waiting to run
Linters / isort (push) Waiting to run
Linters / black (push) Waiting to run
Linters / zizmor (push) Waiting to run
Tests / Windows, SQLite, Python 3.14 (push) Waiting to run
Tests / JavaScript tests (push) Waiting to run
Signed-off-by: JaeHyuck Sa <wogur981208@gmail.com>
2025-12-19 10:09:30 -05:00
Jonathan Biemond
b172cbdf33
Fixed #36808 -- Required name argument in UniqueConstraint signature.
...
By trading ValueError for TypeError for omitted name arguments,
we gain a little clarity.
2025-12-19 09:48:15 -05:00
Samriddha9619
73c987eb3b
Fixed #36701 -- Fixed memory leak in ModelState.
Linters / flake8 (push) Waiting to run
Linters / isort (push) Waiting to run
Linters / black (push) Waiting to run
Linters / zizmor (push) Waiting to run
Tests / Windows, SQLite, Python 3.14 (push) Waiting to run
Tests / JavaScript tests (push) Waiting to run
2025-12-18 17:53:24 -05:00
Mariusz Felisiak
4702b36120
Fixed #27380 -- Added "raw" argument to m2m_changed signals.
Linters / flake8 (push) Waiting to run
Linters / isort (push) Waiting to run
Linters / black (push) Waiting to run
Linters / zizmor (push) Waiting to run
Tests / Windows, SQLite, Python 3.14 (push) Waiting to run
Tests / JavaScript tests (push) Waiting to run
Docs / spelling (push) Has been cancelled
Docs / blacken-docs (push) Has been cancelled
Docs / lint-docs (push) Has been cancelled
2025-12-17 18:37:18 +01:00
Mariusz Felisiak
12d574407c
Refs #27380 -- Added ManyRelatedManager.set_base() hook.
2025-12-17 18:37:18 +01:00
Mariusz Felisiak
6fc2406fc5
Refs #27380 -- Made ManyRelatedManager.set() use *_base() hooks.
2025-12-17 18:37:18 +01:00
Mariusz Felisiak
c3b6c29691
Refs #27380 -- Made ManyRelatedManager.add()/clear()/remove() implementation more consistent.
...
This also adds _add_base(), _clear_base(), and _remove_base() internal
hooks.
2025-12-17 18:37:18 +01:00
Pravin Kamble
4774adfaa1
Fixed #32568 -- Replaced mark_safe() with SafeString for literal values.
...
Replaced instances of mark_safe('some string literal') with
SafeString to avoid the overhead of managing lazy objects.
Thanks Tim McCurrach for the idea and David Smith and Jacob Walls
for reviews.
2025-12-17 12:15:18 -05:00
varunkasyap
0d8548e583
Fixed #36747 -- Parsed weeks from ISO 8601 format in parse_duration().
2025-12-17 10:19:05 -05:00
Clifford Gama
6cc1231285
Fixed #36800 -- Restored ManyToManyField renaming in BaseDatabaseSchemaEditor.alter_field().
...
Docs / spelling (push) Waiting to run
Docs / blacken-docs (push) Waiting to run
Docs / lint-docs (push) Waiting to run
Linters / flake8 (push) Waiting to run
Linters / isort (push) Waiting to run
Linters / black (push) Waiting to run
Linters / zizmor (push) Waiting to run
Tests / Windows, SQLite, Python 3.14 (push) Waiting to run
Tests / JavaScript tests (push) Waiting to run
Regression in f9a44cc0fa .
Now that ManyToManyField is no longer concrete the decision of whether or not
it should be altered, which is also relied on by field renaming, should take
into consideration name changes even if it doesn't have a column associated
with it, as auto-created many-to-many relationship table names are a base of it.
Note that there is room for optimization here where a rename can be entirely
avoided if ManyToManyField.db_table remains stable between .name changes, just
like we do with Field.db_column remaining stable, but since this is a
regression and meant to be backported the current patch focuses on correctness
over further improvements.
Thanks Josik for the report.
Co-authored-by: Simon Charette <charette.s@gmail.com>
2025-12-16 17:45:34 -05:00
Mridul Dhall
d1a4979fa5
Fixed #36594 -- Improved UniqueConstraint's nulls_distinct system check message.
...
Docs / spelling (push) Waiting to run
Docs / blacken-docs (push) Waiting to run
Docs / lint-docs (push) Waiting to run
Linters / flake8 (push) Waiting to run
Linters / isort (push) Waiting to run
Linters / black (push) Waiting to run
Linters / zizmor (push) Waiting to run
Tests / Windows, SQLite, Python 3.14 (push) Waiting to run
Tests / JavaScript tests (push) Waiting to run
Clarified that the nulls_distinct argument is not supported, as opposed
to certain values for the argument.
Thanks Russell Owen for the report.
2025-12-16 15:06:10 -05:00
Marc Gibbons
922c4cf972
Fixed #36783 -- Ensured proper handling of multi-value QueryDicts in querystring template tag.
...
Docs / spelling (push) Waiting to run
Docs / blacken-docs (push) Waiting to run
Docs / lint-docs (push) Waiting to run
Linters / flake8 (push) Waiting to run
Linters / isort (push) Waiting to run
Linters / black (push) Waiting to run
Linters / zizmor (push) Waiting to run
Tests / Windows, SQLite, Python 3.14 (push) Waiting to run
Tests / JavaScript tests (push) Waiting to run
Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
Co-authored-by: Natalia <124304+nessita@users.noreply.github.com>
2025-12-15 18:58:41 -03:00
Jacob Walls
0071cb1efd
Refs #36652 -- Avoided missing imports in a temporary file generated in a migration test.
Linters / flake8 (push) Waiting to run
Linters / isort (push) Waiting to run
Linters / black (push) Waiting to run
Linters / zizmor (push) Waiting to run
Tests / Windows, SQLite, Python 3.14 (push) Waiting to run
Tests / JavaScript tests (push) Waiting to run
2025-12-15 15:24:57 -05:00
Michal Mládek
2ce5cb0f7a
Fixed #26434 -- Removed faulty clearing of ordering field when missing from explicit grouping.
...
Co-authored-by: Simon Charette <charette.s@gmail.com>
2025-12-15 15:23:51 -05:00
Mariusz Felisiak
0174a85770
Fixed #36765 -- Added support for stored GeneratedFields on Oracle 23ai/26ai (23.7+).
...
Docs / spelling (push) Has been cancelled
Docs / blacken-docs (push) Has been cancelled
Docs / lint-docs (push) Has been cancelled
Linters / flake8 (push) Has been cancelled
Linters / isort (push) Has been cancelled
Linters / black (push) Has been cancelled
Linters / zizmor (push) Has been cancelled
Tests / Windows, SQLite, Python 3.14 (push) Has been cancelled
Tests / JavaScript tests (push) Has been cancelled
Thanks Jacob Walls for the review.
2025-12-13 16:38:04 +01:00
Lily Acorn
e95468ed97
Refs #36735 -- Supported shift parameter for UUID7 on PostgreSQL.
Docs / spelling (push) Has been cancelled
Docs / blacken-docs (push) Has been cancelled
Docs / lint-docs (push) Has been cancelled
Linters / flake8 (push) Has been cancelled
Linters / isort (push) Has been cancelled
Linters / black (push) Has been cancelled
Linters / zizmor (push) Has been cancelled
Tests / Windows, SQLite, Python 3.14 (push) Has been cancelled
Tests / JavaScript tests (push) Has been cancelled
2025-12-12 11:50:36 -05:00
Lily Acorn
accceec949
Fixed #36735 -- Added UUID4 and UUID7 database functions.
...
Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
2025-12-12 11:17:08 -05:00
David Sanders
8932a67725
Refs #35444 -- Clarified StringAgg deprecation notice in docs/ref/contrib/postgres/aggregates.txt.
Docs / spelling (push) Waiting to run
Docs / blacken-docs (push) Waiting to run
Docs / lint-docs (push) Waiting to run
Linters / flake8 (push) Waiting to run
Linters / isort (push) Waiting to run
Linters / black (push) Waiting to run
Linters / zizmor (push) Waiting to run
Tests / Windows, SQLite, Python 3.14 (push) Waiting to run
Tests / JavaScript tests (push) Waiting to run
2025-12-11 12:59:09 -05:00
Jake Howard
1651140a80
Included ASGI servers when noting what the server does.
2025-12-11 12:42:17 -05:00
Pravin Kamble
dae08cf55b
Fixed #36769 -- Avoided visiting deeply nested nodes in XML deserializer.
...
Only children at one level of depth need to be visited.
Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
2025-12-11 12:38:04 -05:00
Carlton Gibson
37eb890969
Noted testing uses for ContentTypeManager.clear_cache() method.
...
It is often necessary to reset the cache between tests, or after
preparing test state, when using content types. Django's test suite
already does this when needed, but users will need to do similar in
their own tests.
2025-12-11 12:34:43 -05:00
Jacob Walls
cd6278c4c0
Refs #27890 -- Avoided overwriting TMPDIR in runtests.py under forkserver mode.
...
This variable should only be set once. Under forkserver, this module
was getting executed multiple times, causing nested temporary dirs
that didn't clean up properly, raising FileNotFoundError.
This similar to #27890 although a slightly different cause.
2025-12-11 12:10:52 -05:00
Pravin Kamble
2d5a780eb5
Fixed #36789 -- Added missing PDF file for docs/internals/_images/contribution_process.svg.
...
The PDF is needed to build the PDF version of the whole docs.
2025-12-11 13:38:49 -03:00
Jacob Walls
7b80b21863
Refs #36499 -- Adjusted test_strip_tags following Python behavior change for incomplete entities.
2025-12-11 11:28:49 -05:00
Clifford Gama
7b54ddd5e6
Refs #36025 -- Made get_prep_lookup() pass output_field when wrapping direct values in Value.
...
Linters / flake8 (push) Waiting to run
Linters / isort (push) Waiting to run
Linters / black (push) Waiting to run
Linters / zizmor (push) Waiting to run
Tests / Windows, SQLite, Python 3.14 (push) Waiting to run
Tests / JavaScript tests (push) Waiting to run
Previously, only strings were supplied with an output_field when wrapping
direct value iterable elements in Value expressions for ExpressionList. This
caused problems for __in lookups on JSONField when using expressions
alongside direct values, as JSONField values can have different types which
need to be adapted by the field's get_db_prep_value().
Refs #36689 .
Thanks Jacob Walls for the review.
2025-12-10 17:45:51 -05:00
Clifford Gama
9b8e4c6d7d
Refs #36689 -- Serialized JSONIn rhs parameters wrapped in Value expressions.
2025-12-10 17:45:51 -05:00
Clifford Gama
66fed37ecb
Fixed #36689 -- Fixed top-level JSONField __in lookup failures on MySQL and Oracle.
...
Added a JSONIn lookup to handle correct serialization and extraction
for JSONField top-level __in queries on backends without native JSON
support. KeyTransformIn now subclasses JSONIn.
Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
Thanks Jacob Walls for the report and review.
2025-12-10 17:45:51 -05:00
Tim Graham
bbabbac936
Added tests for MultiPointField, MultiLineStringField, and GeometryCollectionField.
Linters / flake8 (push) Waiting to run
Linters / isort (push) Waiting to run
Linters / black (push) Waiting to run
Linters / zizmor (push) Waiting to run
Tests / Windows, SQLite, Python 3.14 (push) Waiting to run
Tests / JavaScript tests (push) Waiting to run
2025-12-09 20:07:20 -05:00
varunkasyap
3ccef1d669
Fixed #36768 -- Optimized string concatenation in File.__iter__().
2025-12-09 16:45:13 -05:00
Jacob Walls
334308efae
Fixed #36778 -- Extended advice to sanitize input before using in query expressions.
...
Docs / spelling (push) Has been cancelled
Docs / blacken-docs (push) Has been cancelled
Docs / lint-docs (push) Has been cancelled
Thanks Clifford Gama and Simon Charette for reviews.
2025-12-08 10:25:24 -05:00
Adam Johnson
af60ae48d9
Refs #35581 -- Fixed email image inline attachment example.
...
1. Added imports and setup for clarity.
2. Removed adding `<` and `>` to Content-ID, as `make_msgid()` already
includes them.
3. Removed `$` from reference in HTML, and instead stripped `<>` there, as
required by HTML `cid:` references.
2025-12-08 09:44:19 -05:00
saurabh
e726254a38
Refs #36620 -- Added contributor documentation for code coverage reports.
...
Docs / spelling (push) Waiting to run
Docs / blacken-docs (push) Waiting to run
Docs / lint-docs (push) Waiting to run
This was included in the original reverted patch:
a89183e638
Follow-up to 26b0e2bb92 .
2025-12-07 09:06:32 -05:00