mirrors/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-09-30 13:51:16 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Avoid PEP 604 isinstance errors for starred tuples (#3527)

Browse source
This commit is contained in:
Charlie Marsh 2023-03-14 18:08:43 -04:00 • committed by GitHub
parent 58353a4bf4
commit 2545869797
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
crates/ruff/resources/test/fixtures/pyupgrade/UP038.py vendored
View file

@ -6,3 +6,4 @@ issubclass("yes", int) # OK
isinstance(1, int | float) # OK isinstance(1, int | float) # OK
issubclass("yes", int | str) # OK issubclass("yes", int | str) # OK
isinstance(1, ()) # OK isinstance(1, ()) # OK
isinstance(1, (int, *(str, bytes))) # OK

10
crates/ruff/src/rules/pyupgrade/rules/use_pep604_isinstance.rs
View file

@ -79,9 +79,19 @@ pub fn use_pep604_isinstance(checker: &mut Checker, expr: &Expr, func: &Expr, ar
}; };
if let Some(types) = args.get(1) { if let Some(types) = args.get(1) {
if let ExprKind::Tuple { elts, .. } = &types.node { if let ExprKind::Tuple { elts, .. } = &types.node {
// Ex) `()`
if elts.is_empty() { if elts.is_empty() {
return; return;
} }
// Ex) `(*args,)`
if elts
.iter()
.any(|elt| matches!(elt.node, ExprKind::Starred { .. }))
{
return;
}
let mut diagnostic = let mut diagnostic =
Diagnostic::new(IsinstanceWithTuple { kind }, Range::from(expr)); Diagnostic::new(IsinstanceWithTuple { kind }, Range::from(expr));
if checker.patch(diagnostic.kind.rule()) { if checker.patch(diagnostic.kind.rule()) {