mirrors/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-09-30 22:01:18 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

Enrich messages of SARIF results (#13180)

Browse source
This commit is contained in:
Luo Peng 2024-09-01 19:13:22 +08:00 • committed by GitHub
parent 1be8c2e340
commit dd5d0d523c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 6 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

8
crates/ruff_linter/src/message/sarif.rs
View file

@ -121,7 +121,7 @@ impl SarifResult {
Ok(Self { Ok(Self {
rule: message.rule(), rule: message.rule(),
level: "error".to_string(), level: "error".to_string(),
message: message.name().to_string(), message: message.body().to_string(),
uri: url::Url::from_file_path(&path) uri: url::Url::from_file_path(&path)
.map_err(|()| anyhow::anyhow!("Failed to convert path to URL: {}", path.display()))? .map_err(|()| anyhow::anyhow!("Failed to convert path to URL: {}", path.display()))?
.to_string(), .to_string(),
@ -141,7 +141,7 @@ impl SarifResult {
Ok(Self { Ok(Self {
rule: message.rule(), rule: message.rule(),
level: "error".to_string(), level: "error".to_string(),
message: message.name().to_string(), message: message.body().to_string(),
uri: path.display().to_string(), uri: path.display().to_string(),
start_line: start_location.row, start_line: start_location.row,
start_column: start_location.column, start_column: start_location.column,
@ -215,6 +215,10 @@ mod tests {
.unwrap(); .unwrap();
let results = sarif["runs"][0]["results"].as_array().unwrap(); let results = sarif["runs"][0]["results"].as_array().unwrap();
assert_eq!(results.len(), 3); assert_eq!(results.len(), 3);
assert_eq!(
results[0]["message"]["text"].as_str().unwrap(),
"`os` imported but unused"
);
assert!(rules.len() > 3); assert!(rules.len() > 3);
} }
} }