2048 commits

Author	SHA1	Message	Date
Wei Lee	f8c9665742	[airflow] Extend names moved from core to provider (AIR303) (#15216) ... ## Summary Many core Airflow features have been deprecated and moved to Airflow Providers since users might need to install an additional package (e.g., `apache-airflow-provider-fab==1.0.0`); a separate rule (AIR303) is created for this. * `airflow.kubernetes.kubernetes_helper_functions.add_pod_suffix` → `airflow.providers.cncf.kubernetes.kubernetes_helper_functions.add_pod_suffix` * `airflow.kubernetes.kubernetes_helper_functions.annotations_for_logging_task_metadata` → `airflow.providers.cncf.kubernetes.kubernetes_helper_functions.annotations_for_logging_task_metadata` * `airflow.kubernetes.kubernetes_helper_functions.annotations_to_key` → `airflow.providers.cncf.kubernetes.kubernetes_helper_functions.annotations_to_key` * `airflow.kubernetes.kubernetes_helper_functions.create_pod_id` → `airflow.providers.cncf.kubernetes.kubernetes_helper_functions.create_pod_id` * `airflow.kubernetes.kubernetes_helper_functions.get_logs_task_metadata` → `airflow.providers.cncf.kubernetes.kubernetes_helper_functions.get_logs_task_metadata` * `airflow.kubernetes.kubernetes_helper_functions.rand_str` → `airflow.providers.cncf.kubernetes.kubernetes_helper_functions.rand_str` * `airflow.kubernetes.pod.Port` → `kubernetes.client.models.V1ContainerPort` * `airflow.kubernetes.pod.Resources` → `kubernetes.client.models.V1ResourceRequirements` * `airflow.kubernetes.pod_launcher.PodLauncher` → `airflow.providers.cncf.kubernetes.pod_launcher.PodLauncher` * `airflow.kubernetes.pod_launcher.PodStatus` → `airflow.providers.cncf.kubernetes.pod_launcher.PodStatus` * `airflow.kubernetes.pod_launcher_deprecated.PodLauncher` → `airflow.providers.cncf.kubernetes.pod_launcher_deprecated.PodLauncher` * `airflow.kubernetes.pod_launcher_deprecated.PodStatus` → `airflow.providers.cncf.kubernetes.pod_launcher_deprecated.PodStatus` * `airflow.kubernetes.pod_launcher_deprecated.get_kube_client` → `airflow.providers.cncf.kubernetes.kube_client.get_kube_client` * `airflow.kubernetes.pod_launcher_deprecated.PodDefaults` → `airflow.providers.cncf.kubernetes.pod_generator_deprecated.PodDefaults` * `airflow.kubernetes.pod_runtime_info_env.PodRuntimeInfoEnv` → `kubernetes.client.models.V1EnvVar` * `airflow.kubernetes.volume.Volume` → `kubernetes.client.models.V1Volume` * `airflow.kubernetes.volume_mount.VolumeMount` → `kubernetes.client.models.V1VolumeMount` * `airflow.kubernetes.k8s_model.K8SModel` → `airflow.providers.cncf.kubernetes.k8s_model.K8SModel` * `airflow.kubernetes.k8s_model.append_to_pod` → `airflow.providers.cncf.kubernetes.k8s_model.append_to_pod` * `airflow.kubernetes.kube_client._disable_verify_ssl` → `airflow.kubernetes.airflow.providers.cncf.kubernetes.kube_client._disable_verify_ssl` * `airflow.kubernetes.kube_client._enable_tcp_keepalive` → `airflow.kubernetes.airflow.providers.cncf.kubernetes.kube_client._enable_tcp_keepalive` * `airflow.kubernetes.kube_client.get_kube_client` → `airflow.kubernetes.airflow.providers.cncf.kubernetes.kube_client.get_kube_client` * `airflow.kubernetes.pod_generator.datetime_to_label_safe_datestring` → `airflow.providers.cncf.kubernetes.pod_generator.datetime_to_label_safe_datestring` * `airflow.kubernetes.pod_generator.extend_object_field` → `airflow.kubernetes.airflow.providers.cncf.kubernetes.pod_generator.extend_object_field` * `airflow.kubernetes.pod_generator.label_safe_datestring_to_datetime` → `airflow.providers.cncf.kubernetes.pod_generator.label_safe_datestring_to_datetime` * `airflow.kubernetes.pod_generator.make_safe_label_value` → `airflow.providers.cncf.kubernetes.pod_generator.make_safe_label_value` * `airflow.kubernetes.pod_generator.merge_objects` → `airflow.providers.cncf.kubernetes.pod_generator.merge_objects` * `airflow.kubernetes.pod_generator.PodGenerator` → `airflow.providers.cncf.kubernetes.pod_generator.PodGenerator` * `airflow.kubernetes.pod_generator.PodGeneratorDeprecated` → `airflow.providers.cncf.kubernetes.pod_generator.PodGenerator` * `airflow.kubernetes.pod_generator.PodDefaults` → `airflow.providers.cncf.kubernetes.pod_generator_deprecated.PodDefaults` * `airflow.kubernetes.pod_generator.add_pod_suffix` → `airflow.providers.cncf.kubernetes.kubernetes_helper_functions.add_pod_suffix` * `airflow.kubernetes.pod_generator.rand_str` → `airflow.providers.cncf.kubernetes.kubernetes_helper_functions.rand_str` * `airflow.kubernetes.pod_generator_deprecated.make_safe_label_value` → `airflow.providers.cncf.kubernetes.pod_generator_deprecated.make_safe_label_value` * `airflow.kubernetes.pod_generator_deprecated.PodDefaults` → `airflow.providers.cncf.kubernetes.pod_generator_deprecated.PodDefaults` * `airflow.kubernetes.pod_generator_deprecated.PodGenerator` → `airflow.providers.cncf.kubernetes.pod_generator_deprecated.PodGenerator` * `airflow.kubernetes.secret.Secret` → `airflow.providers.cncf.kubernetes.secret.Secret` * `airflow.kubernetes.secret.K8SModel` → `airflow.providers.cncf.kubernetes.k8s_model.K8SModel` ## Test Plan A test fixture has been included for the rule.	2025-01-02 10:30:12 +05:30
InSync	af95f6b577	[pycodestyle] Avoid false positives and negatives related to type parameter default syntax (E225, E251) (#15214)	2025-01-01 11:28:25 +01:00
David Salvisberg	1ef0f615f1	[flake8-type-checking] Improve flexibility of runtime-evaluated-decorators (#15204) ... Co-authored-by: Micha Reiser <micha@reiser.io>	2024-12-31 16:28:10 +00:00
Wei Lee	32de5801f7	[airflow]: extend names moved from core to provider (AIR303) (#15196)	2024-12-31 15:16:07 +01:00
InSync	cfd6093579	[pydocstyle] Add setting to ignore missing documentation for*args and **kwargs parameters (D417) (#15210) ... Co-authored-by: Micha Reiser <micha@reiser.io>	2024-12-31 12:16:55 +01:00
Arnav Gupta	3c9021ffcb	[ruff] Implement falsy-dict-get-fallback (RUF056) (#15160) ... Co-authored-by: Micha Reiser <micha@reiser.io>	2024-12-31 11:40:51 +01:00
Wei Lee	68d2466832	[airflow] Remove additional spaces (AIR302) (#15211) ... <!-- Thank you for contributing to Ruff! To help us out with reviewing, please consider the following: - Does this pull request include a summary of the change? (See below.) - Does this pull request include a descriptive title? - Does this pull request include references to any relevant issues? --> ## Summary <!-- What's the purpose of the change? What does it do, and why? --> During https://github.com/astral-sh/ruff/pull/15209, additional spaces was accidentally added to the rule `airflow.operators.latest_only.LatestOnlyOperator`. This PR fixes this issue ## Test Plan <!-- How was it tested? --> A test fixture has been included for the rule.	2024-12-31 13:58:11 +05:30
Avasam	ecf00cdf6a	Fix incorrect doc in shebang-not-executable (EXE001) and add git+windows solution to executable bit (#15208) ... ## Summary I noticed that the solution mentioned in [shebang-not-executable (EXE001)](https://docs.astral.sh/ruff/rules/shebang-not-executable/#shebang-not-executable-exe001) was incorrect and likely copy-pasted from [shebang-missing-executable-file (EXE002)](https://docs.astral.sh/ruff/rules/shebang-missing-executable-file/#shebang-missing-executable-file-exe002) It was telling users to remove the executable bit from a non-executable file. Which does nothing. I also noticed locally that: - `chmod` wouldn't cause any file change to be noticed by git (`EXE` was also passing locally) under WSL - Using git allows anyone to fix this lint across OSes, for projects with CIs using git So I added a solution using [git update-index --chmod](https://git-scm.com/docs/git-update-index#Documentation/git-update-index.txt---chmod-x) ## Test Plan No test plan, doc changes only. As for running the chmod commands: https://github.com/python/typeshed/pull/13346	2024-12-31 11:05:44 +05:30
Dhruv Manilawala	86bdc2e7b1	Refactor Airflow removal in 3 code (#15209) ... This PR contains a couple of refactors for the Airflow removal in 3 code, nothing major just some minor nits.	2024-12-31 05:27:12 +00:00
Wei Lee	253c274afa	[airflow] Extend rule to check class attributes, methods, arguments (AIR302) (#15083) ... ## Summary Airflow 3.0 removes various deprecated functions, members, modules, and other values. They have been deprecated in 2.x, but the removal causes incompatibilities that we want to detect. This PR add rules for the following. * Removed class attribute * `airflow.providers_manager.ProvidersManager.dataset_factories` → `airflow.providers_manager.ProvidersManager.asset_factories` * `airflow.providers_manager.ProvidersManager.dataset_uri_handlers` → `airflow.providers_manager.ProvidersManager.asset_uri_handlers` * `airflow.providers_manager.ProvidersManager.dataset_to_openlineage_converters` → `airflow.providers_manager.ProvidersManager.asset_to_openlineage_converters` * `airflow.lineage.hook.DatasetLineageInfo.dataset` → `airflow.lineage.hook.AssetLineageInfo.asset` * Removed class method (subclasses in airflow should also checked) * `airflow.secrets.base_secrets.BaseSecretsBackend.get_conn_uri` → `airflow.secrets.base_secrets.BaseSecretsBackend.get_conn_value` * `airflow.secrets.base_secrets.BaseSecretsBackend.get_connections` → `airflow.secrets.base_secrets.BaseSecretsBackend.get_connection` * `airflow.hooks.base.BaseHook.get_connections` → use `get_connection` * `airflow.datasets.BaseDataset.iter_datasets` → `airflow.sdk.definitions.asset.BaseAsset.iter_assets` * `airflow.datasets.BaseDataset.iter_dataset_aliases` → `airflow.sdk.definitions.asset.BaseAsset.iter_asset_aliases` * Removed constructor args (subclasses in airflow should also checked) * argument `filename_template` in`airflow.utils.log.file_task_handler.FileTaskHandler` * in `BaseOperator` * `sla` * `task_concurrency` → `max_active_tis_per_dag` * in `BaseAuthManager` * `appbuilder` * Removed class variable (subclasses anywhere should be checked) * in `airflow.plugins_manager.AirflowPlugin` * `executors` (from #43289) * `hooks` * `operators` * `sensors` * Replaced names * `airflow.hooks.base_hook.BaseHook` → `airflow.hooks.base.BaseHook` * `airflow.operators.dagrun_operator.TriggerDagRunLink` → `airflow.operators.trigger_dagrun.TriggerDagRunLink` * `airflow.operators.dagrun_operator.TriggerDagRunOperator` → `airflow.operators.trigger_dagrun.TriggerDagRunOperator` * `airflow.operators.python_operator.BranchPythonOperator` → `airflow.operators.python.BranchPythonOperator` * `airflow.operators.python_operator.PythonOperator` → `airflow.operators.python.PythonOperator` * `airflow.operators.python_operator.PythonVirtualenvOperator` → `airflow.operators.python.PythonVirtualenvOperator` * `airflow.operators.python_operator.ShortCircuitOperator` → `airflow.operators.python.ShortCircuitOperator` * `airflow.operators.latest_only_operator.LatestOnlyOperator` → `airflow.operators.latest_only.LatestOnlyOperator` In additional to the changes above, this PR also add utility functions and improve docstring. ## Test Plan A test fixture is included in the PR.	2024-12-31 09:49:18 +05:30
InSync	2a1aa29366	[pylint] Detect nested methods correctly (PLW1641) (#15032) ... Co-authored-by: Micha Reiser <micha@reiser.io>	2024-12-30 16:55:14 +01:00
InSync	280ba75100	[flake8-pie] Allow cast(SomeType, ...) (PIE796) (#15141)	2024-12-30 15:52:35 +01:00
wookie184	04d538113a	Add all PEP-585 names to UP006 rule (#5454) ... Co-authored-by: Charlie Marsh <charlie.r.marsh@gmail.com> Co-authored-by: dylwil3 <dylwil3@gmail.com> Co-authored-by: Micha Reiser <micha@reiser.io>	2024-12-30 12:21:42 +01:00
InSync	0b15f17939	[flake8-simplify] More precise inference for dictionaries (SIM300) (#15164) ... Co-authored-by: Micha Reiser <micha@reiser.io>	2024-12-30 10:41:33 +00:00
InSync	d4ee6abf4a	Visit PEP 764 inline TypedDicts' keys as non-type-expressions (#15073) ... ## Summary Resolves #10812. ## Test Plan `cargo nextest run` and `cargo insta test`.	2024-12-30 15:04:55 +05:30
InSync	901b7dd8f8	[flake8-use-pathlib] Catch redundant joins in PTH201 and avoid syntax errors (#15177) ... ## Summary Resolves #10453, resolves #15165. ## Test Plan `cargo nextest run` and `cargo insta test`.	2024-12-30 03:31:35 +00:00
David Salvisberg	f170932585	[flake8-type-checking] Disable TC006 & TC007 in stub files (#15179) ... Fixes: #15176 ## Summary Neither of these rules make any sense in stub files. Technically TC007 should already not have triggered, due to the typing only context of the binding, but it's better to be explicit. Keeping TC008 enabled on the other hand makes sense to me, although we could probably be more aggressive with unquoting in a typing runtime context. ## Test Plan `cargo nextest run`	2024-12-29 14:39:16 -05:00
Wei Lee	2288cc7478	[airflow]: extend names moved from core to provider (AIR303) (#15159)	2024-12-27 17:04:02 +00:00
Enoch Kan	79816f965c	Fix SyntaxError in example replacement snippet in nonlocal-without-binding (#15157)	2024-12-27 12:15:13 +00:00
Victorien	2419fdb2ef	Fix typo in LogicalLine docstring (#15150)	2024-12-26 18:45:45 +01:00
Wei Lee	5d6aae839e	[airflow]: extend moved names (AIR303) (#15145)	2024-12-26 10:55:07 +01:00
sobolevn	8b9c843c72	Fix docs highlight in dict_iter_missing_items.rs (#15140)	2024-12-25 18:52:17 +01:00
Enoch Kan	5bc9d6d3aa	Rename rules currently not conforming to naming convention (#15102) ... ## Summary This pull request renames 19 rules which currently do not conform to Ruff's [naming convention](https://github.com/astral-sh/ruff/blob/main/CONTRIBUTING.md#rule-naming-convention). ## Description Fixes astral-sh/ruff#15009.	2024-12-23 15:48:45 -06:00
Harutaka Kawamura	8440f3ea9f	[fastapi] Update FAST002 to check keyword-only arguments (#15119) ... ## Summary Close #15117. Update `FAST002` to check keyword-only arguments. ## Test Plan New test case	2024-12-23 15:32:42 +05:30
InSync	9eb73cb7e0	[pycodestyle] Preserve original value format (E731) (#15097) ... Co-authored-by: Micha Reiser <micha@reiser.io>	2024-12-23 09:29:46 +00:00
Arnav Gupta	b6c8f5d79e	Fix RUF200 doc to have name and email in single object (#15099) ... ## Summary Closes #14975 by modifying the docstring of the InvalidPyprojectToml rule. Previously the docs were incorrectly stating that author name and emails must be individual items in the authors list, rather than part of a single object for each respective author. ## Test Plan This was a docstring change, no tests needed.	2024-12-23 10:30:16 +05:30
InSync	60e433c3b5	Rename round_applicability.rs back to unnecessary_cast_to_int.rs (#15095)	2024-12-21 21:32:26 +01:00
TomerBin	2fb6b320d8	Use TypeChecker for detecting fastapi routes (#15093)	2024-12-21 15:45:28 +01:00
InSync	bd023c4500	[ruff] Detect more strict-integer expressions (RUF046) (#14833) ... Co-authored-by: Micha Reiser <micha@reiser.io>	2024-12-21 14:23:26 +00:00
my1e5	d3f51cf3a6	[pydocstyle] Split on first whitespace character (D403) (#15082) ... ## Summary This PR fixes an issue where Ruff's `D403` rule (`first-word-uncapitalized`) was not detecting some single-word edge cases that are picked up by `pydocstyle`. The change involves extracting the first word of the docstring by identifying the first whitespace character. This is consistent with `pydocstyle` which uses `.split()` - see 8d0cdfc93e/src/pydocstyle/checker.py (L581C13-L581C64) ## Example Here is a playground example - https://play.ruff.rs/eab9ea59-92cf-4e44-b1a9-b54b7f69b178 ```py def example1(): """foo""" def example2(): """foo Hello world! """ def example3(): """foo bar Hello world! """ def example4(): """ foo """ def example5(): """ foo bar """ ``` `pydocstyle` detects all five cases: ```bash $ pydocstyle test.py --select D403 dev/test.py:2 in public function `example1`: D403: First word of the first line should be properly capitalized ('Foo', not 'foo') dev/test.py:5 in public function `example2`: D403: First word of the first line should be properly capitalized ('Foo', not 'foo') dev/test.py:11 in public function `example3`: D403: First word of the first line should be properly capitalized ('Foo', not 'foo') dev/test.py:17 in public function `example4`: D403: First word of the first line should be properly capitalized ('Foo', not 'foo') dev/test.py:22 in public function `example5`: D403: First word of the first line should be properly capitalized ('Foo', not 'foo') ``` Ruff (`0.8.4`) fails to catch example2 and example4. ## Test Plan * Added two new test cases to cover the previously missed single-word docstring cases.	2024-12-20 12:55:50 -06:00
David Salvisberg	089a98e904	[ruff] Adds an allowlist for unsafe-markup-use (RUF035) (#15076) ... Closes: #14523 ## Summary Adds a whitelist of calls allowed to be used within a `markupsafe.Markup` call. ## Test Plan `cargo nextest run`	2024-12-20 09:36:12 +00:00
Harutaka Kawamura	6195c026ff	[flake8-comprehensions] Skip C416 if comprehension contains unpacking (#14909) ... <!-- Thank you for contributing to Ruff! To help us out with reviewing, please consider the following: - Does this pull request include a summary of the change? (See below.) - Does this pull request include a descriptive title? - Does this pull request include references to any relevant issues? --> ## Summary <!-- What's the purpose of the change? What does it do, and why? --> Fix #11482. Applies https://github.com/adamchainz/flake8-comprehensions/pull/205 to ruff. `C416` should be skipped if comprehension contains unpacking. Here's an example: ```python list_of_lists = [[1, 2], [3, 4]] # ruff suggests `list(list_of_lists)` here, but that would change the result. # `list(list_of_lists)` is not `[(1, 2), (3, 4)]` a = [(x, y) for x, y in list_of_lists] # This is equivalent to `list(list_of_lists)` b = [x for x in list_of_lists] ``` ## Test Plan <!-- How was it tested? --> Existing checks --------- Signed-off-by: harupy <hkawamura0130@gmail.com>	2024-12-20 14:35:30 +05:30
KotlinIsland	c0b0491703	Update docs for eq-without-hash (#14885) ... ## Summary resolves #14883 This PR removes the known limitation section in the documentation of `eq-without-hash`. That is not actually a limitation as a subclass overriding the `__eq__` method would have its `__hash__` set to `None` implicitly. The user should explicitly inherit the `__hash__` method from the parent class. ## Test Plan <img width="619" alt="Screenshot 2024-12-20 at 2 02 47 PM" src="https://github.com/user-attachments/assets/552defcd-25e1-4153-9ab9-e5b9d5fbe8cc" /> --------- Co-authored-by: Dhruv Manilawala <dhruvmanila@gmail.com>	2024-12-20 14:03:16 +05:30
Micha Reiser	51863b460b	Use &'static str for Replacement (#15075) ... ## Summary Smaller nits follow up to https://github.com/astral-sh/ruff/pull/15054 because I wasn't able to push to the branch directly. ## Test Plan `cargo test`	2024-12-20 07:36:21 +00:00
Wei Lee	14a5a2629e	[airflow]: extend removed method calls (AIR302) (#15054) ... ## Summary Airflow 3.0 removes various deprecated functions, members, modules, and other values. They have been deprecated in 2.x, but the removal causes incompatibilities that we want to detect. This PR deprecates the following names and add a function for removed methods * `airflow.datasets.manager.DatasetManager.register_dataset_change` → `airflow.assets.manager.AssetManager.register_asset_change` * `airflow.datasets.manager.DatasetManager.create_datasets` → `airflow.assets.manager.AssetManager.create_assets` * `airflow.datasets.manager.DatasetManager.notify_dataset_created` → `airflow.assets.manager.AssetManager.notify_asset_created` * `airflow.datasets.manager.DatasetManager.notify_dataset_changed` → `airflow.assets.manager.AssetManager.notify_asset_changed` * `airflow.datasets.manager.DatasetManager.notify_dataset_alias_created` → `airflow.assets.manager.AssetManager.notify_asset_alias_created` * `airflow.providers.amazon.auth_manager.aws_auth_manager.AwsAuthManager.is_authorized_dataset` → `airflow.providers.amazon.auth_manager.aws_auth_manager.AwsAuthManager.is_authorized_asset` * `airflow.lineage.hook.HookLineageCollector.create_dataset` → `airflow.lineage.hook.HookLineageCollector.create_asset` * `airflow.lineage.hook.HookLineageCollector.add_input_dataset` → `airflow.lineage.hook.HookLineageCollector.add_input_asset` * `airflow.lineage.hook.HookLineageCollector.add_output_dataset` → `airflow.lineage.hook.HookLineageCollector.dd_output_asset` * `airflow.lineage.hook.HookLineageCollector.collected_datasets` → `airflow.lineage.hook.HookLineageCollector.collected_assets` * `airflow.providers_manager.ProvidersManager.initialize_providers_dataset_uri_resources` → `airflow.providers_manager.ProvidersManager.initialize_providers_asset_uri_resources` ## Test Plan A test fixture is included in the PR.	2024-12-20 08:30:30 +01:00
Dhruv Manilawala	3bb0dac235	Bump version to 0.8.4 (#15064)	2024-12-19 13:15:42 +00:00
Dylan	596d80cc8e	[perflint] Parenthesize walrus expressions in autofix for manual-list-comprehension (PERF401) (#15050)	2024-12-19 06:56:45 -06:00
Taras Matsyk	85e71ba91a	[flake8-bandit] Check S105 for annotated assignment (#15059) ... ## Summary A follow up PR on https://github.com/astral-sh/ruff/issues/14991 Ruff ignores hardcoded passwords for typed variables. Add a rule to catch passwords in typed code bases ## Test Plan Includes 2 more test typed variables	2024-12-19 12:26:40 +00:00
InSync	f0012df686	Fix typos in RUF043.py (#15044) ... (Accidentally introduced in #14966.)	2024-12-18 15:39:55 +00:00
InSync	ac81c72bf3	[ruff] Ambiguous pattern passed to pytest.raises() (RUF043) (#14966)	2024-12-18 11:53:48 +00:00
David Salvisberg	c0b7c36d43	[ruff] Avoid false positives for RUF027 for typing context bindings. (#15037) ... Closes #14000 ## Summary For typing context bindings we know that they won't be available at runtime. We shouldn't recommend a fix, that will result in name errors at runtime. ## Test Plan `cargo nextest run`	2024-12-18 08:50:49 +01:00
InSync	c9fdb1f5e3	[pylint] Preserve original value format (PLR6104) (#14978) ... ## Summary Resolves #11672. ## Test Plan `cargo nextest run` and `cargo insta test`. --------- Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>	2024-12-17 16:07:07 +01:00
Wei Lee	867a8f9497	feat(AIR302): extend the following rules (#15015) ... ## Summary Airflow 3.0 removes various deprecated functions, members, modules, and other values. They have been deprecated in 2.x, but the removal causes incompatibilities that we want to detect. This PR deprecates the following names. * `airflow.api_connexion.security.requires_access_dataset` → `airflow.api_connexion.security.requires_access_asset` * `airflow.auth.managers.base_auth_manager.is_authorized_dataset` → `airflow.auth.managers.base_auth_manager.is_authorized_asset` * `airflow.auth.managers.models.resource_details.DatasetDetails` → `airflow.auth.managers.models.resource_details.AssetDetails` * `airflow.lineage.hook.DatasetLineageInfo` → `airflow.lineage.hook.AssetLineageInfo` * `airflow.security.permissions.RESOURCE_DATASET` → `airflow.security.permissions.RESOURCE_ASSET` * `airflow.www.auth.has_access_dataset` → `airflow.www.auth.has_access_dataset.has_access_asset` * remove `airflow.datasets.DatasetAliasEvent` * `airflow.datasets.Dataset` → `airflow.sdk.definitions.asset.Asset` * `airflow.Dataset` → `airflow.sdk.definitions.asset.Asset` * `airflow.datasets.DatasetAlias` → `airflow.sdk.definitions.asset.AssetAlias` * `airflow.datasets.DatasetAll` → `airflow.sdk.definitions.asset.AssetAll` * `airflow.datasets.DatasetAny` → `airflow.sdk.definitions.asset.AssetAny` * `airflow.datasets.metadata` → `airflow.sdk.definitions.asset.metadata` * `airflow.datasets.expand_alias_to_datasets` → `airflow.sdk.definitions.asset.expand_alias_to_assets` * `airflow.datasets.manager.dataset_manager` → `airflow.assets.manager` * `airflow.datasets.manager.resolve_dataset_manager` → `airflow.assets.resolve_asset_manager` * `airflow.datasets.manager.DatasetManager` → `airflow.assets.AssetManager` * `airflow.listeners.spec.dataset.on_dataset_created` → `airflow.listeners.spec.asset.on_asset_created` * `airflow.listeners.spec.dataset.on_dataset_changed` → `airflow.listeners.spec.asset.on_asset_changed` * `airflow.timetables.simple.DatasetTriggeredTimetable` → `airflow.timetables.simple.AssetTriggeredTimetable` * `airflow.timetables.datasets.DatasetOrTimeSchedule` → `airflow.timetables.assets.AssetOrTimeSchedule` * `airflow.providers.amazon.auth_manager.avp.entities.AvpEntities.DATASET` → `airflow.providers.amazon.auth_manager.avp.entities.AvpEntities.ASSET` * `airflow.providers.amazon.aws.datasets.s3.create_dataset` → `airflow.providers.amazon.aws.assets.s3.create_asset` * `airflow.providers.amazon.aws.datasets.s3.convert_dataset_to_openlineage` → `airflow.providers.amazon.aws.datasets.s3.convert_dataset_to_openlineage` * `airflow.providers.amazon.aws.datasets.s3.sanitize_uri` → `airflow.providers.amazon.aws.assets.s3.sanitize_uri` * `airflow.providers.common.io.datasets.file.convert_dataset_to_openlineage` → `airflow.providers.common.io.assets.file.convert_asset_to_openlineage` * `airflow.providers.common.io.datasets.file.sanitize_uri` → `airflow.providers.common.io.assets.file.sanitize_uri` * `airflow.providers.common.io.datasets.file.create_dataset` → `airflow.providers.common.io.assets.file.create_asset` * `airflow.providers.google.datasets.bigquery.sanitize_uri` → `airflow.providers.google.assets.bigquery.sanitize_uri` * `airflow.providers.google.datasets.gcs.create_dataset` → `airflow.providers.google.assets.gcs.create_asset` * `airflow.providers.google.datasets.gcs.sanitize_uri` → `airflow.providers.google.assets.gcs.sanitize_uri` * `airflow.providers.google.datasets.gcs.convert_dataset_to_openlineage` → `airflow.providers.google.assets.gcs.convert_asset_to_openlineage` * `airflow.providers.fab.auth_manager.fab_auth_manager.is_authorized_dataset` → `airflow.providers.fab.auth_manager.fab_auth_manager.is_authorized_asset` * `airflow.providers.openlineage.utils.utils.DatasetInfo` → `airflow.providers.openlineage.utils.utils.AssetInfo` * `airflow.providers.openlineage.utils.utils.translate_airflow_dataset` → `airflow.providers.openlineage.utils.utils.translate_airflow_asset` * `airflow.providers.postgres.datasets.postgres.sanitize_uri` → `airflow.providers.postgres.assets.postgres.sanitize_uri` * `airflow.providers.mysql.datasets.mysql.sanitize_uri` → `airflow.providers.mysql.assets.mysql.sanitize_uri` * `airflow.providers.trino.datasets.trino.sanitize_uri` → `airflow.providers.trino.assets.trino.sanitize_uri` In additional to the newly added rules above, the message for `airflow.contrib.*` and `airflow.subdag.*` has been extended, `airflow.sensors.external_task.ExternalTaskSensorLink` error has been fixed and the test fixture has been reorganized ## Test Plan A test fixture is included in the PR.	2024-12-17 08:32:48 +01:00
w0nder1ng	e22718f25f	[perflint] Simplify finding the loop target in PERF401 (#15025) ... Fixes #15012. ```python def f(): # panics when the code can't find the loop variable values = [1, 2, 3] result = [] for i in values: result.append(i + 1) del i ``` I'm not sure exactly why this test case panics, but I suspect the `del i` removes the binding from the semantic model's symbols. I changed the code to search for the correct binding by directly iterating through the bindings. Since we know exactly which binding we want, this should find the loop variable without any complications.	2024-12-17 08:30:32 +01:00
Dylan	6a5eff6017	[pydocstyle] Skip leading whitespace for D403 (#14963) ... This PR introduces three changes to `D403`, which has to do with capitalizing the first word in a docstring. 1. The diagnostic and fix now skip leading whitespace when determining what counts as "the first word". 2. The name has been changed to `first-word-uncapitalized` from `first-line-capitalized`, for both clarity and compliance with our rule naming policy. 3. The diagnostic message and documentation has been modified slightly to reflect this. Closes #14890	2024-12-16 09:09:27 -06:00
w0nder1ng	4a7536dc94	[perflint] Fix panic in perf401 (#14971) ... Fixes #14969. The issue was that this line: ```rust let from_assign_to_loop = TextRange::new(binding_stmt.end(), for_stmt.start()); ``` was not safe if the binding was after the target. The only way (at least that I can think of) this can happen is if they are in different scopes, so it now checks for that before checking if there are usages between the two.	2024-12-15 16:22:04 +01:00
Dimitri Papadopoulos Orfanos	2d15d7d1af	Improve the documentation of E201/E202 (#14983) ... ## Summary The summary is misleading, as well as the `whitespace-after-open-bracket` and `whitespace-before-close-bracket` names - it's not only brackets, but also parentheses and braces. Align the documentation with the actual behaviour. Don't change the names, but align the documentation with the behaviour. ## Test Plan No test (documentation).	2024-12-15 16:20:04 +01:00
Wei Lee	dfd7f38009	[airflow]: Import modules that has been moved to airflow providers (AIR303) (#14764) ... ## Summary Many core Airflow features have been deprecated and moved to Airflow Providers since users might need to install an additional package (e.g., `apache-airflow-provider-fab==1.0.0`); a separate rule (AIR303) is created for this. As some of the changes only relate to the module/package moved, instead of listing out all the functions, variables, and classes in a module or a package, it warns the user to import from the new path instead of the specific name. The following is the ones that has been moved to `apache-airflow-provider-fab==1.0.0` * module moved * `airflow.api.auth.backend.basic_auth` → `airflow.providers.fab.auth_manager.api.auth.backend.basic_auth` * `airflow.api.auth.backend.kerberos_auth` → `airflow.providers.fab.auth_manager.api.auth.backend.kerberos_auth` * `airflow.auth.managers.fab.api.auth.backend.kerberos_auth` → `airflow.providers.fab.auth_manager.api.auth.backend.kerberos_auth` * `airflow.auth.managers.fab.security_manager.override` → `airflow.providers.fab.auth_manager.security_manager.override` * classes (e.g., functions, classes) moved * `airflow.www.security.FabAirflowSecurityManagerOverride` → `airflow.providers.fab.auth_manager.security_manager.override.FabAirflowSecurityManagerOverride` * `airflow.auth.managers.fab.fab_auth_manager.FabAuthManager` → `airflow.providers.fab.auth_manager.security_manager.FabAuthManager` ## Test Plan A test fixture has been included for the rule.	2024-12-13 10:38:07 +01:00
Krishnan Chandra	be4ce16735	[ruff] Skip SQLModel base classes for mutable-class-default (RUF012) (#14949) ... ## Summary Closes https://github.com/astral-sh/ruff/issues/14892, by adding `sqlmodel.SQLModel` to the list of classes with default copy semantics. ## Test Plan Added a test into `RUF012.py` containing the example from the original issue.	2024-12-12 22:19:21 -06:00
Chandra Kiran G	e5cb4d6388	[flake8-pyi]: More autofixes for redundant-none-literal (PYI061) (#14872) ... Co-authored-by: Alex Waygood <alex.waygood@gmail.com>	2024-12-12 19:44:32 +00:00