1319 commits

Author	SHA1	Message	Date
David Salvisberg	8a7ba5d2df	[flake8-type-checking] Fixes quote_type_expression (#14634)	2024-11-27 18:58:48 +01:00
Brent Westbrook	6fcbe8efb4	[ruff] Detect redirected-noqa in file-level comments (RUF101) (#14635)	2024-11-27 18:25:47 +01:00
Alexandra Valentine-Ketchum	c40b37aa36	N811 & N814: eliminate false positives for single-letter names (#14584) ... Co-authored-by: Micha Reiser <micha@reiser.io> Co-authored-by: Alex Waygood <alex.waygood@gmail.com>	2024-11-27 14:38:36 +00:00
Simon Brugman	11a2929ed7	[ruff] Implement unnecessary-nested-literal (RUF041) (#14323) ... Co-authored-by: Micha Reiser <micha@reiser.io> Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>	2024-11-27 10:01:50 +00:00
InSync	187974eff4	[flake8-use-pathlib] Recommend Path.iterdir() over os.listdir() (PTH208) (#14509) ... Co-authored-by: Micha Reiser <micha@reiser.io>	2024-11-27 09:53:13 +00:00
David Salvisberg	6fd10e2fe7	[flake8-type-checking] Adds implementation for TC007 and TC008 (#12927) ... Co-authored-by: Simon Brugman <sbrugman@users.noreply.github.com> Co-authored-by: Carl Meyer <carl@oddbird.net>	2024-11-27 09:51:20 +01:00
Lokejoke	82c01aa662	[pylint] Implement len-test (PLC1802) (#14309) ... ## Summary This PR implements [`use-implicit-booleaness-not-len` / `C1802`](https://pylint.pycqa.org/en/latest/user_guide/messages/convention/use-implicit-booleaness-not-len.html) > For sequences, (strings, lists, tuples), use the fact that empty sequences are false. --------- Co-authored-by: xbrtnik1 <524841@mail.muni.cz> Co-authored-by: xbrtnik1 <xbrtnik1@mail.muni.cz>	2024-11-26 13:30:17 -06:00
Brent Westbrook	9f446faa6c	[pyflakes] Avoid false positives in @no_type_check contexts (F821, F722) (#14615)	2024-11-26 19:13:43 +00:00
Dylan	24c90d6953	[pylint] Do not wrap function calls in parentheses in the fix for unnecessary-dunder-call (PLC2801) (#14601)	2024-11-26 06:47:01 -06:00
Tzu-ping Chung	fbff4dec3a	[airflow] Avoid implicit DAG schedule (AIR301) (#14581)	2024-11-26 13:38:18 +01:00
Simon Brugman	e4cefd9bf9	Extend test cases for flake8-pyi (#14280)	2024-11-26 09:10:38 +01:00
Lokejoke	9e4ee98109	[ruff] Implement invalid-assert-message-literal-argument (RUF040) (#14488) ... ## Summary This PR implements new rule discussed [here](https://github.com/astral-sh/ruff/discussions/14449). In short, it searches for assert messages which were unintentionally used as a expression to be matched against. ## Test Plan `cargo test` and review of `ruff-ecosystem`	2024-11-25 17:41:07 -06:00
Simon Brugman	c606bf014e	[flake8-pyi] Improve autofix safety for redundant-none-literal (PYI061) (#14583) ... Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>	2024-11-25 17:40:57 +00:00
Simon Brugman	e8fce20736	[ruff] Improve autofix safety for never-union (RUF020) (#14589)	2024-11-25 18:35:07 +01:00
Harutaka Kawamura	fa22bd604a	Fix pytest.mark.parametrize rules to check calls instead of decorators (#14515) ... Co-authored-by: Micha Reiser <micha@reiser.io>	2024-11-25 13:55:18 +01:00
Charlie Marsh	de62e39eba	Use truthiness check in auto_attribs detection (#14562)	2024-11-23 22:06:10 -05:00
InSync	d285717da8	[ruff] Handle attrs's auto_attribs correctly (RUF009) (#14520) ... ## Summary Resolves #14519. ## Test Plan `cargo nextest run` and `cargo insta test`.	2024-11-23 21:46:38 -05:00
InSync	545e9deba3	[flake8-builtins] Exempt private built-in modules (A005) (#14505) ... ## Summary Resolves #12949. ## Test Plan `cargo nextest run` and `cargo insta test`.	2024-11-23 21:39:04 -05:00
Harutaka Kawamura	e3d792605f	[flake8-bugbear] Fix mutable-contextvar-default (B039) to resolve annotated function calls properly (#14532) ... ## Summary <!-- What's the purpose of the change? What does it do, and why? --> Fix #14525 ## Test Plan <!-- How was it tested? --> New test cases --------- Signed-off-by: harupy <hkawamura0130@gmail.com>	2024-11-23 21:29:25 -05:00
Harutaka Kawamura	931fa06d85	Extend invalid-envvar-default (PLW1508) to detect os.environ.get (#14512)	2024-11-22 19:13:58 +00:00
David Salvisberg	e25e7044ba	[flake8-type-checking] Adds implementation for TC006 (#14511) ... Co-authored-by: Micha Reiser <micha@reiser.io>	2024-11-22 15:22:59 +01:00
Alex Waygood	c400725713	[ruff 0.8] [flake8-pytest-style] Remove deprecated rules PT004 and PT005 (#14385) ... Co-authored-by: Micha Reiser <micha@reiser.io>	2024-11-20 13:11:51 +01:00
Alex Waygood	1081694140	[ruff 0.8] [flake8-annotations] Remove deprecated rules ANN101 and ANN102 (#14384) ... Co-authored-by: Micha Reiser <micha@reiser.io>	2024-11-20 13:11:51 +01:00
David Salvisberg	dc05b38165	[ruff 0.8][flake8-type-checking] Rename TCH to TC (#14438) ... Closes #9573	2024-11-20 13:11:51 +01:00
konsti	b46cc6ac0b	Update pyproject-toml to support PEP 639 (#13902) ... Fixes #13869	2024-11-20 13:11:51 +01:00
Alex Waygood	5f6607bf54	[ruff 0.8] Remove deprecated rule UP027 (#14382)	2024-11-20 13:11:51 +01:00
InSync	b9c53a74f9	[pycodestyle] Exempt pytest.importorskip() calls (E402) (#14474) ... ## Summary Resolves #13537. ## Test Plan `cargo nextest run` and `cargo insta test`.	2024-11-19 22:08:15 -05:00
Micha Reiser	dbbe7a773c	Mark UP043 fix unsafe when the type annotation contains any comments (#14458)	2024-11-19 15:24:02 +01:00
InSync	5f09d4a90a	[ruff] re and regex calls with unraw string as first argument (RUF039) (#14446)	2024-11-19 13:44:55 +01:00
InSync	3642381489	[ruff] Add rule forbidding map(int, package.__version__.split('.')) (RUF048) (#14373) ... Co-authored-by: Alex Waygood <alex.waygood@gmail.com>	2024-11-18 13:43:24 +00:00
Steve C	577653551c	[pylint] - use sets when possible for PLR1714 autofix (repeated-equality-comparison) (#14372)	2024-11-18 08:57:43 +01:00
Charlie Marsh	fccbe56d23	Reverse order of __contains__ arguments (#14424) ... ## Summary Closes https://github.com/astral-sh/ruff/issues/14423.	2024-11-18 03:58:12 +00:00
InSync	0a27c9dabd	[flake8-pie] Mark fix as unsafe if the following statement is a string literal (PIE790) (#14393) ... ## Summary Resolves #12616. ## Test Plan `cargo nextest run` and `cargo insta test`. --------- Co-authored-by: Charlie Marsh <charlie.r.marsh@gmail.com>	2024-11-18 02:30:06 +00:00
InSync	3c9e76eb66	[flake8-datetimez] Also exempt .time() (DTZ901) (#14394) ... ## Summary Resolves #14378. ## Test Plan `cargo nextest run` and `cargo insta test`. --------- Co-authored-by: Charlie Marsh <charlie.r.marsh@gmail.com>	2024-11-18 02:24:35 +00:00
Simon Brugman	1fbed6c325	[ruff] Implement redundant-bool-literal (RUF038) (#14319) ... ## Summary Implements `redundant-bool-literal` ## Test Plan <!-- How was it tested? --> `cargo test` The ecosystem results are all correct, but for `Airflow` the rule is not relevant due to the use of overloading (and is marked as unsafe correctly). --------- Co-authored-by: Charlie Marsh <charlie.r.marsh@gmail.com>	2024-11-16 21:52:51 +00:00
Simon Brugman	78210b198b	[flake8-pyi] Implement redundant-none-literal (PYI061) (#14316) ... ## Summary `Literal[None]` can be simplified into `None` in type annotations. Surprising to see that this is not that rare: - https://github.com/langchain-ai/langchain/blob/master/libs/langchain/langchain/chat_models/base.py#L54 - https://github.com/sqlalchemy/sqlalchemy/blob/main/lib/sqlalchemy/sql/annotation.py#L69 - https://github.com/jax-ml/jax/blob/main/jax/numpy/__init__.pyi#L961 - https://github.com/huggingface/huggingface_hub/blob/main/src/huggingface_hub/inference/_common.py#L179 ## Test Plan `cargo test` Reviewed all ecosystem results, and they are true positives. --------- Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com> Co-authored-by: Charlie Marsh <charlie.r.marsh@gmail.com>	2024-11-16 18:22:51 +00:00
Simon Brugman	4a2310b595	[flake8-pyi] Implement autofix for redundant-numeric-union (PYI041) (#14273) ... ## Summary This PR adds autofix for `redundant-numeric-union` (`PYI041`) There are some comments below to explain the reasoning behind some choices that might help review. <!-- What's the purpose of the change? What does it do, and why? --> Resolves part of https://github.com/astral-sh/ruff/issues/14185. ## Test Plan <!-- How was it tested? --> --------- Co-authored-by: Micha Reiser <micha@reiser.io> Co-authored-by: Charlie Marsh <charlie.r.marsh@gmail.com>	2024-11-16 18:13:23 +00:00
Shaygan Hooshyari	6591775cd9	[flake8-type-checking] Skip quoting annotation if it becomes invalid syntax (TCH001) (#14285) ... Fix: #13934 ## Summary Current implementation has a bug when the current annotation contains a string with single and double quotes. TL;DR: I think these cases happen less than other use cases of Literal. So instead of fixing them we skip the fix in those cases. One of the problematic cases: ``` from typing import Literal from third_party import Type def error(self, type1: Type[Literal["'"]]): pass ``` The outcome is: ``` - def error(self, type1: Type[Literal["'"]]): + def error(self, type1: "Type[Literal[''']]"): ``` While it should be: ``` "Type[Literal['\'']" ``` The solution in this case is that we check if there’s any quotes same as the quote style we want to use for this Literal parameter then escape that same quote used in the string. Also this case is not uncommon to have: <https://grep.app/search?current=2&q=Literal["'> But this can get more complicated for example in case of: ``` - def error(self, type1: Type[Literal["\'"]]): + def error(self, type1: "Type[Literal[''']]"): ``` Here we escaped the inner quote but in the generated annotation it gets removed. Then we flip the quote style of the Literal paramter and the formatting is wrong. In this case the solution is more complicated. 1. When generating the string of the source code preserve the backslash. 2. After we have the annotation check if there isn’t any escaped quote of the same type we want to use for the Literal parameter. In this case check if we have any `’` without `\` before them. This can get more complicated since there can be multiple backslashes so checking for only `\’` won’t be enough. Another problem is when the string contains `\n`. In case of `Type[Literal["\n"]]` we generate `'Type[Literal["\n"]]'` and both pyright and mypy reject this annotation. https://pyright-play.net/?code=GYJw9gtgBALgngBwJYDsDmUkQWEMoAySMApiAIYA2AUAMaXkDOjUAKoiQNqsC6AXFAB0w6tQAmJYLBKMYAfQCOAVzCk5tMChjlUjOQCNytANaMGjABYAKRiUrAANLA4BGAQHJ2CLkVIVKnABEADoogTw87gCUfNRQ8VAITIyiElKksooqahpaOih6hiZmTNa29k7w3m5sHJy%2BZFRBoeE8MXEJScxAA ## Test Plan I added test cases for the original code in the reported issue and two more cases for backslash and new line. --------- Co-authored-by: Dhruv Manilawala <dhruvmanila@gmail.com>	2024-11-15 11:11:46 +00:00
Dylan	8095ff0e55	enforce required imports even with useless alias (#14287) ... This PR handles a panic that occurs when applying unsafe fixes if a user inserts a required import (I002) that has a "useless alias" in it, like `import numpy as numpy`, and also selects PLC0414 (useless-import-alias) In this case, the fixes alternate between adding the required import statement, then removing the alias, until the recursion limit is reached. See linked issue for an example. Closes #14283 --------- Co-authored-by: Charlie Marsh <charlie.r.marsh@gmail.com>	2024-11-14 15:39:38 -06:00
Simon Brugman	a40bc6a460	[ruff] Implement none-not-at-end-of-union (RUF036) (#14314)	2024-11-14 19:37:13 +01:00
InSync	d8b1afbc6e	[ruff] Also report problems for attrs dataclasses in preview mode (RUF008, RUF009) (#14327) ... Co-authored-by: Alex Waygood <alex.waygood@gmail.com>	2024-11-14 15:13:49 +00:00
David Salvisberg	89aa804b2d	[flake8-type-checking] Fix false positives for typing.Annotated (#14311)	2024-11-13 12:17:52 +00:00
InSync	f789b12705	[flake8-logging] Root logger calls (LOG015) (#14302)	2024-11-13 09:11:55 +00:00
InSync	5c548dcc04	[flake8-datetimez] Usages of datetime.max/datetime.min (DTZ901) (#14288) ... ## Summary Resolves #13217. ## Test Plan `cargo nextest run` and `cargo insta test`. --------- Co-authored-by: Charlie Marsh <charlie.r.marsh@gmail.com>	2024-11-12 20:36:07 +00:00
Simon Brugman	bd30701980	[flake8-pyi] Improve autofix for nested and mixed type unions unnecessary-type-union (PYI055) (#14272) ... ## Summary This PR improves the fix for `PYI055` to be able to handle nested and mixed type unions. It also marks the fix as unsafe when comments are present. <!-- What's the purpose of the change? What does it do, and why? --> ## Test Plan <!-- How was it tested? -->	2024-11-12 15:33:51 -05:00
Harutaka Kawamura	2b6d66b793	Fix pytest-raises-too-broad (PT011) to flag pytest.raises call with keyword expected_exception (#14298) ... ## Summary <!-- What's the purpose of the change? What does it do, and why? --> `pytest-raises-too-broad (PT011)` should be raised when `expected_exception` is provided as a keyword argument. ```python def test_foo(): with pytest.raises(ValueError): # raises PT011 raise ValueError("Can't divide 1 by 0") # This is minor but a valid pytest.raises call with pytest.raises(expected_exception=ValueError): # doesn't raise PT011 but should raise ValueError("Can't divide 1 by 0") ``` `pytest.raises` doc: https://docs.pytest.org/en/8.3.x/reference/reference.html#pytest.raises ## Test Plan <!-- How was it tested? --> Unit tests Signed-off-by: harupy <hkawamura0130@gmail.com>	2024-11-12 14:28:42 -05:00
InSync	13a1483f1e	[flake8-pyi] Add "replace with Self" fix (PYI019) (#14238) ... Co-authored-by: Micha Reiser <micha@reiser.io>	2024-11-12 11:13:15 +00:00
InSync	be69f61b3e	[flake8-simplify] Infer "unknown" truthiness for literal iterables whose items are all unpacks (SIM222) (#14263) ... ## Summary Resolves #14237. ## Test Plan `cargo nextest run` and `cargo insta test`. --------- Co-authored-by: Dhruv Manilawala <dhruvmanila@gmail.com>	2024-11-11 15:23:34 -05:00
David Salvisberg	f82ee8ea59	[flake8-markupsafe] Adds Implementation for MS001 via RUF035 (#14224) ... Co-authored-by: Micha Reiser <micha@reiser.io>	2024-11-11 18:30:03 +00:00
Simon Brugman	f8aae9b1d6	[flake8-pyi] Mark fix as unsafe when type annotation contains comments for duplicate-literal-member (PYI062) (#14268)	2024-11-11 12:48:14 +00:00