1995 commits

Author	SHA1	Message	Date
Charlie Marsh	ed1dd09d02	Refine some perflint rules (#5484) ... ## Summary Removing some false positives based on running over `zulip`. `PERF401` now also detects cases like: ```py original = list(range(10000)) filtered = [] for i in original: filtered.append(i * i) ``` Previously, these were caught by the list-copy rule, but these too need comprehensions.	2023-07-03 13:53:17 -04:00
Charlie Marsh	ca497fabbd	Remove some diagnostics.extend calls (#5483) ... ## Summary It's more efficient (and more idiomatic for us) to pass in the `Checker` directly.	2023-07-03 16:47:23 +00:00
Charlie Marsh	00fbbe4223	Remove some additional manual iterator matches (#5482) ... ## Summary I've done a few of these PRs, I thought I'd caught them all, but missed this pattern.	2023-07-03 16:29:59 +00:00
Charlie Marsh	dadad0e9ed	Remove some allocations in argument detection (#5481) ... ## Summary Drive-by PR to remove some allocations around argument name matching.	2023-07-03 12:21:26 -04:00
Charlie Marsh	d2450c25ab	Audit remove_argument usages to use end-of-function (#5480) ... ## Summary This PR applies the fix in #5478 to a variety of other call-sites, and fixes some other range hygienic stuff in the rules that were modified.	2023-07-03 12:21:01 -04:00
Harutaka Kawamura	1e4b88969c	Fix unnecessary-encode-utf8 to fix encode on parenthesized strings correctly (#5478) ... ## Summary Fixes #5477 ## Test Plan New test cases.	2023-07-03 10:11:09 -04:00
Louis Dispa	dc072537e5	Fix python_formatter generate.py with rust path (#5475) ... ## Summary This PR fix an issue with the `generate.py` file of the python formatter. Since https://github.com/astral-sh/ruff/pull/5369 the [node.rs file](f51dc20497/crates/ruff_python_ast/src/node.rs) used to generate the types now has `ast::` in the enum. ```rust pub enum AnyNode { ModModule(ModModule), ModInteractive(ModInteractive), ModExpression(ModExpression), ModFunctionType(ModFunctionType), ... ``` And now: ```rust pub enum AnyNode { ModModule(ast::ModModule), ModInteractive(ast::ModInteractive), ModExpression(ast::ModExpression), ModFunctionType(ast::ModFunctionType), ... ``` The python script was not parsing rust paths. This PR adds the possibility to have it. ## Test Plan This was tested locally. ### Script output Before ``` ['ast::ModModule),', 'ast::ModInteractive),', 'ast::ModExpression),', 'ast::ModFunctionType),', 'ast::StmtFunctionDef),', 'ast::StmtAsyncFunctionDef),', 'ast::StmtClassDef),', 'ast::StmtReturn),', 'ast::StmtDelete),', 'ast::StmtAssign),', 'ast::StmtAugAssign),', 'ast::StmtAnnAssign),', 'ast::StmtFor),', 'ast::StmtAsyncFor),', 'ast::StmtWhile),', 'ast::StmtIf),', 'ast::StmtWith),', 'ast::StmtAsyncWith),', 'ast::StmtMatch),', 'ast::StmtRaise),', 'ast::StmtTry),', 'ast::StmtTryStar),', 'ast::StmtAssert),', 'ast::StmtImport),', 'ast::StmtImportFrom),', 'ast::StmtGlobal),', 'ast::StmtNonlocal),', 'ast::StmtExpr),', 'ast::StmtPass),', 'ast::StmtBreak),', 'ast::StmtContinue),', 'ast::ExprBoolOp),', 'ast::ExprNamedExpr),', 'ast::ExprBinOp),', 'ast::ExprUnaryOp),', 'ast::ExprLambda),', 'ast::ExprIfExp),', 'ast::ExprDict),', 'ast::ExprSet),', 'ast::ExprListComp),', 'ast::ExprSetComp),', 'ast::ExprDictComp),', 'ast::ExprGeneratorExp),', 'ast::ExprAwait),', 'ast::ExprYield),', 'ast::ExprYieldFrom),', 'ast::ExprCompare),', 'ast::ExprCall),', 'ast::ExprFormattedValue),', 'ast::ExprJoinedStr),', 'ast::ExprConstant),', 'ast::ExprAttribute),', 'ast::ExprSubscript),', 'ast::ExprStarred),', 'ast::ExprName),', 'ast::ExprList),', 'ast::ExprTuple),', 'ast::ExprSlice),', 'ast::ExceptHandlerExceptHandler),', 'ast::PatternMatchValue),', 'ast::PatternMatchSingleton),', 'ast::PatternMatchSequence),', 'ast::PatternMatchMapping),', 'ast::PatternMatchClass),', 'ast::PatternMatchStar),', 'ast::PatternMatchAs),', 'ast::PatternMatchOr),', 'ast::TypeIgnoreTypeIgnore),', 'Comprehension),', 'Arguments),', 'Arg),', 'ArgWithDefault),', 'Keyword),', 'Alias),', 'WithItem),', 'MatchCase),', 'Decorator),'] error: unexpected closing delimiter: `)` --> <stdin>:3:55 | 2 | use ruff_formatter::{write, Buffer, FormatResult}; | - this opening brace... - ...matches this closing brace 3 | use rustpython_parser::ast::ast::ModModule),; | ^ unexpected closing delimiter Traceback (most recent call last): File "/Users/ldispa/Documents/perso/ruff/crates/ruff_python_formatter/generate.py", line 100, in <module> node_path.write_text(rustfmt(code)) ^^^^^^^^^^^^^ File "/Users/ldispa/Documents/perso/ruff/crates/ruff_python_formatter/generate.py", line 12, in rustfmt return check_output(["rustfmt", "--emit=stdout"], input=code, text=True) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/opt/homebrew/Cellar/python@3.11/3.11.4_1/Frameworks/Python.framework/Versions/3.11/lib/python3.11/subprocess.py", line 466, in check_output return run(*popenargs, stdout=PIPE, timeout=timeout, check=True, ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/opt/homebrew/Cellar/python@3.11/3.11.4_1/Frameworks/Python.framework/Versions/3.11/lib/python3.11/subprocess.py", line 571, in run raise CalledProcessError(retcode, process.args, subprocess.CalledProcessError: Command '['rustfmt', '--emit=stdout']' returned non-zero exit status 1. ``` After: ``` ['ModModule', 'ModInteractive', 'ModExpression', 'ModFunctionType', 'StmtFunctionDef', 'StmtAsyncFunctionDef', 'StmtClassDef', 'StmtReturn', 'StmtDelete', 'StmtAssign', 'StmtAugAssign', 'StmtAnnAssign', 'StmtFor', 'StmtAsyncFor', 'StmtWhile', 'StmtIf', 'StmtWith', 'StmtAsyncWith', 'StmtMatch', 'StmtRaise', 'StmtTry', 'StmtTryStar', 'StmtAssert', 'StmtImport', 'StmtImportFrom', 'StmtGlobal', 'StmtNonlocal', 'StmtExpr', 'StmtPass', 'StmtBreak', 'StmtContinue', 'ExprBoolOp', 'ExprNamedExpr', 'ExprBinOp', 'ExprUnaryOp', 'ExprLambda', 'ExprIfExp', 'ExprDict', 'ExprSet', 'ExprListComp', 'ExprSetComp', 'ExprDictComp', 'ExprGeneratorExp', 'ExprAwait', 'ExprYield', 'ExprYieldFrom', 'ExprCompare', 'ExprCall', 'ExprFormattedValue', 'ExprJoinedStr', 'ExprConstant', 'ExprAttribute', 'ExprSubscript', 'ExprStarred', 'ExprName', 'ExprList', 'ExprTuple', 'ExprSlice', 'ExceptHandlerExceptHandler', 'PatternMatchValue', 'PatternMatchSingleton', 'PatternMatchSequence', 'PatternMatchMapping', 'PatternMatchClass', 'PatternMatchStar', 'PatternMatchAs', 'PatternMatchOr', 'TypeIgnoreTypeIgnore', 'Comprehension', 'Arguments', 'Arg', 'ArgWithDefault', 'Keyword', 'Alias', 'WithItem', 'MatchCase', 'Decorator'] ```	2023-07-03 16:07:57 +02:00
konsti	7ac9e0252e	Document Checking formatter stability and panics (#5415) ... This adds the documentation, but ideally we should add the CI first	2023-07-03 11:22:19 +02:00
konsti	ca6ff72404	Change generator formatting dummy to include NOT_YET_IMPLEMENTED (#5464) ... ## Summary Change generator formatting dummy to include `NOT_YET_IMPLEMENTED`. This makes it easier to correctly identify them as dummies ## Test Plan This is a dummy change	2023-07-03 09:11:14 +02:00
Charlie Marsh	94ac2c4e1b	Reorganize some flake8-pyi rules (#5472)	2023-07-03 04:39:22 +00:00
qdegraaf	93b2bd7184	[perflint] Add PERF401 and PERF402 rules (#5298) ... ## Summary Adds `PERF401` and `PERF402` mirroring `W8401` and `W8402` from https://github.com/tonybaloney/perflint Implementation is not super smart but should be at parity with upstream implementation judging by: c07391c176/perflint/comprehension_checker.py (L42-L73) It essentially checks: - If the body of a for-loop is just one statement - If that statement is an `if` and the if-statement contains a call to `append()` we flag `PERF401` and suggest a list comprehension - If that statement is a plain call to `append()` or `insert()` we flag `PERF402` and suggest `list()` or `list.copy()` I've set the violation to only flag the first append call in a long `if-else` statement for `PERF401`. Happy to change this to some other location or make it multiple violations if that makes more sense. ## Test Plan Fixtures were added with the relevant scenarios for both rules ## Issue Links Refers: https://github.com/astral-sh/ruff/issues/4789	2023-07-03 04:03:09 +00:00
Justin Prieto	0bff4ed4d3	[flake8-pyi] Implement PYI002, PYI003, PYI004, PYI005 (#5457) ... ## Summary Implements flake8-pyi checks 002, 003, 004, 005. The logic is a bit complex, as you can see in the [original code](57921813c1/pyi.py (L1403C18-L1403C18)). ref: #848 ## Test Plan Updated snapshot tests. Ran flake8 to double check lints, and ran ruff with all PYI lints enabled to check for incorrect overlapping lint errors.	2023-07-02 23:52:16 -04:00
Anders Kaseorg	df13e69c3c	Format let-else with rustfmt nightly (#5461) ... Support for `let…else` formatting was just merged to nightly (rust-lang/rust#113225). Rerun `cargo fmt` with Rust nightly 2023-07-02 to pick this up. Followup to #939. Signed-off-by: Anders Kaseorg <andersk@mit.edu>	2023-07-03 02:13:35 +00:00
Charlie Marsh	c8b9a46e2b	[pyupgrade] Restore the keep-runtime-typing setting (#5470) ... ## Summary This PR reverts #4427. See the included documentation for a detailed explanation. Closes #5434.	2023-07-03 02:11:31 +00:00
Charlie Marsh	6cc04d64e4	[flake8-django] Skip duplicate violations in DJ012 (#5469) ... ## Summary This PR reduces the noise from `DJ012` by emitting a single violation when you have multiple consecutive violations of the same "type". For example, given: ```py class MultipleConsecutiveFields(models.Model): """Model that contains multiple out-of-order field definitions in a row.""" class Meta: verbose_name = "test" first_name = models.CharField(max_length=32) last_name = models.CharField(max_length=32) ``` It's convenient to only error on `first_name`, and not `last_name`, since we're really flagging that the _section_ is out-of-order. Closes #5465.	2023-07-02 21:09:49 -04:00
Charlie Marsh	d0b2fffb87	[numpy] Add numpy-deprecated-function (NPY003) (#5468) ... ## Summary Closes #5456.	2023-07-02 20:50:14 -04:00
Charlie Marsh	b32d1e8d78	Detect consecutive, non-newline-delimited NumPy sections (#5467) ... ## Summary Given a docstring like: ```py def f(a: int, b: int) -> int: """Showcase function. Parameters ---------- a : int _description_ b : int _description_ Returns ------- int _description """ ``` We were failing to identify `Returns` as a section, because the previous line was neither empty nor ended with punctuation. This was causing a false negative, where by we weren't flagging a missing line before `Returns`. So, the very reason for the rule (no blank line) was causing us to fail to catch it. Note that, we did have a test case for this, which was working properly: ```py def f() -> int: """Showcase function. Parameters ---------- Returns ------- """ ``` ...because the line before `Returns` "ends in a punctuation mark" (`-`). Closes #5442.	2023-07-02 20:29:45 -04:00
Charlie Marsh	af7051b976	Include BaseException in B017 rule (#5466) ... Closes #5462.	2023-07-02 20:18:33 -04:00
Micha Reiser	f0ec9ecd67	Show BestFitting mode if it isn't FirstLine (#5452)	2023-06-30 09:49:00 +00:00
Micha Reiser	f9129e435a	Normalize '\r' in string literals to '\n' ... <!-- Thank you for contributing to Ruff! To help us out with reviewing, please consider the following: - Does this pull request include a summary of the change? (See below.) - Does this pull request include a descriptive title? - Does this pull request include references to any relevant issues? --> ## Summary This PR normalizes line endings inside of strings to `\n` as required by the printer. <!-- What's the purpose of the change? What does it do, and why? --> ## Test Plan I added a new test using `\r\n` and ran the ecosystem check. There are no remaining end of line panics. https://gist.github.com/MichaReiser/8f36b1391ca7b48475b3a4f592d74ff4 <!-- How was it tested? -->	2023-06-30 10:13:23 +02:00
Micha Reiser	dc65007fe9	Use rayon to parallelize the stability check ... <!-- Thank you for contributing to Ruff! To help us out with reviewing, please consider the following: - Does this pull request include a summary of the change? (See below.) - Does this pull request include a descriptive title? - Does this pull request include references to any relevant issues? --> ## Summary This PR uses rayon to parallelize the stability check by scheduling each project as its own task. <!-- What's the purpose of the change? What does it do, and why? --> ## Test Plan I ran the ecosystem check. It now makes use of all cores (except at the end, there are some large projects). ## Performance The check now completes in minutes where it took about 30 minutes before. <!-- How was it tested? -->	2023-06-30 10:05:25 +02:00
Micha Reiser	9c2a75284b	Preserve parentheses around left side of binary expression ... <!-- Thank you for contributing to Ruff! To help us out with reviewing, please consider the following: - Does this pull request include a summary of the change? (See below.) - Does this pull request include a descriptive title? - Does this pull request include references to any relevant issues? --> ## Summary This PR fixes an issue where the binary expression formatting removed parentheses around the left hand side of an expression. <!-- What's the purpose of the change? What does it do, and why? --> ## Test Plan I added a new regression test and re-ran the ecosystem check. It brings down the `check-formatter-stability` output from a 3.4MB file down to 900KB. <!-- How was it tested? -->	2023-06-30 09:52:14 +02:00
Micha Reiser	ae25638b0b	Update Black tests (#5438)	2023-06-30 06:32:50 +00:00
Micha Reiser	955e9ef821	Fix invalid syntax for binary expression in unary op (#5370)	2023-06-29 08:09:26 +02:00
Micha Reiser	38189ed913	Fix invalid printer IR error (#5422)	2023-06-29 08:09:13 +02:00
David Szotten	ca5e10b5ea	format StmtTryStar (#5418)	2023-06-29 08:07:33 +02:00
Charlie Marsh	a973019358	Rewrite a variety of .contains() calls as matches! statements (#5432) ... ## Summary These have the potential to be much more efficient, as we've seen in the past.	2023-06-28 22:42:27 -04:00
Charlie Marsh	aa887d5a1d	Use "manual" fixability for E731 in shadowed context (#5430) ... ## Summary This PR makes E731 a "manual" fix in one other context: when the lambda is shadowing another variable in the scope. Function declarations (with shadowing) cause issues for type checkers, and so rewriting an annotation, e.g., in branches of an `if` statement can lead to failures. Closes https://github.com/astral-sh/ruff/issues/5421.	2023-06-28 22:00:06 -04:00
Charlie Marsh	72f7f11bac	Use matches! for reserved attribute lookup (#5431)	2023-06-29 01:52:11 +00:00
Tom Kuson	5aa2a90e17	Add documentation to flake8-logging-format rules (#5417) ... ## Summary Completes the documentation for the `flake8-logging-format` rules. Related to #2646. I included both the `flake8-logging-format` recommendation to use the `extra` keyword and the Pylint recommendation to pass format values as parameters so that formatting is done lazily, as #970 suggests the Pylint logging rules are covered by this ruleset. Using lazy formatting via parameters is probably more common than avoiding formatting entirely in favour of the `extra` argument, regardless. ## Test Plan `python scripts/check_docs_formatted.py`	2023-06-29 01:30:11 +00:00
Charlie Marsh	0e89c94947	Run shadowed-variable analyses in deferred handlers (#5181) ... ## Summary This PR extracts a bunch of complex logic from `add_binding`, instead running the the shadowing rules in the deferred handler, thereby decoupling the binding phase (during which we build up the semantic model) from the analysis phase, and generally making `add_binding` much more focused. This was made possible by improving the semantic model to better handle deletions -- previously, we'd "lose track" of bindings if they were deleted, which made this kind of refactor impossible. ## Test Plan We have good automated coverage for this, but I want to benchmark it separately.	2023-06-29 00:08:18 +00:00
Charlie Marsh	c5e20505f8	Remove an unsafe access in the resolver (#5428)	2023-06-28 19:08:10 +00:00
Charlie Marsh	69c4b7fa11	Add dedicated struct for implicit imports (#5427) ... ## Summary This was some feedback on a prior PR that I decided to act on separately.	2023-06-28 18:55:43 +00:00
Charlie Marsh	0e12eb3071	Add a snapshot test for native module resolution (#5423)	2023-06-28 18:16:39 +00:00
Charlie Marsh	864f50a3a4	Remove all unwrap calls from the resolver (#5426)	2023-06-28 18:06:17 +00:00
Charlie Marsh	4d90a5a9bc	Move resolver tests out to top-level (#5424) ... ## Summary These are really tests for the entire crate.	2023-06-28 13:25:37 -04:00
Charlie Marsh	1d2d015bc5	Make standard input detection robust to invalid arguments (#5393) ... ## Summary This PR fixes a silent failure that manifested itself in https://github.com/astral-sh/ruff-vscode/issues/238. In short, if the user provided invalid arguments to Ruff in the VS Code extension (like `"ruff.args": ["a"]`), then we generated something like the following command: ```console /path/to/ruff --force-exclude --no-cache --no-fix --format json - --fix a --stdin-filename /path/to/file.py ``` Since this contains both `-` and `a` as the "input files", Ruff would treat this as if we're linting the files names `-` and `a`, rather than linting standard input. This PR modifies out standard input detection to force standard input when `--stdin-filename` is present, or at least one file is `-`. (We then warn and ignore the others.)	2023-06-28 14:52:23 +00:00
Charlie Marsh	ea7bb199bc	Fill-in missing implementation for is_native_module_file_name (#5410) ... ## Summary This was just an oversight -- the last remaining `todo!()` that I never filled in. We clearly don't have any test coverage for it yet, but this mimics the Pyright implementation.	2023-06-28 14:50:54 +00:00
Charlie Marsh	979049b2a6	Make lib iteration platform-specific (#5406)	2023-06-28 13:52:20 +00:00
Charlie Marsh	6587fb844a	Add snapshot tests for resolver (#5404) ... ## Summary This PR adds some snapshot tests for the resolver based on executing resolutions within a "mock" of the Airflow repo (that is: a folder that contains a subset of the repo's files, but all empty, and with an only-partially-complete virtual environment). It's intended to act as a lightweight integration test, to enable us to test resolutions on a "real" project without adding a dependency on Airflow itself.	2023-06-28 13:38:51 +00:00
Dhruv Manilawala	a68a86e18b	fixup! Consider Jupyter index for code frames (--show-source) (#5402) (#5414)	2023-06-28 10:25:05 +00:00
Christian Clauss	b42d76494c	types.rs: fnmatch url should point to current Python docs (#5413) ... Like #5412	2023-06-28 15:54:13 +05:30
David Szotten	c7adb9117f	format StmtAsyncWith (#5376) ... Co-authored-by: Micha Reiser <micha@reiser.io>	2023-06-28 10:21:44 +00:00
David Szotten	1979103ec0	Format StmtTry (#5222) ... Co-authored-by: Micha Reiser <micha@reiser.io>	2023-06-28 10:02:15 +00:00
Christian Clauss	9e2fd0c620	ruff rule SLOT uses URL to current Python docs (#5412) ... <!-- Thank you for contributing to Ruff! To help us out with reviewing, please consider the following: - Does this pull request include a summary of the change? (See below.) - Does this pull request include a descriptive title? - Does this pull request include references to any relevant issues? --> ## Summary <!-- What's the purpose of the change? What does it do, and why? --> Currently the URL at the bottom of the `ruff rule SLOT00x` output points to Python 3.7 docs. Given that Python 3.7 is now end-of-life (as of yesterday), let's instead point users to the current Python docs. ## Test Plan <!-- How was it tested? -->	2023-06-28 09:48:52 +00:00
Charlie Marsh	366edc5a3f	Fix string annotation in docs (#5411)	2023-06-28 03:29:56 +00:00
Dhruv Manilawala	2aecaf5060	Consider Jupyter index for code frames (--show-source) (#5402) ... ## Summary Consider Jupyter index for code frames (`--show-source`). This solves two problems as mentioned in the linked issue: > Omit any contents from adjoining cells If the Jupyter index is present, we'll use that to check if the surrounding lines belong to the same cell as the content line. If not, we'll skip that line until we either reach the one which does or we reach the content line. > code frame line number If the Jupyter index is present, we'll use that to get the actual start line in corresponding to the computed start index. ## Test Plan `cargo run --bin ruff -- check --no-cache --isolated --select=ALL --show-source /path/to/notebook.ipynb` fixes: #5395	2023-06-28 08:54:51 +05:30
Marti Raudsepp	2c99b268c6	Exclude docstrings from PYI053 (#5405) ... ## Summary The `Y053` rule of `flake8-pyi` ignores docstrings, it only triggers on other string literals. The separate `Y021/PYI021` rule exists to disallow docstrings. ## Test Plan Added some `# OK` test cases to `PYI053.py(i)` files.	2023-06-28 00:19:20 +00:00
Charlie Marsh	56f73de0cb	Misc. clean-up for import resolver (#5401) ... ## Summary Renaming functions, adding documentation, refactoring the test infrastructure a bit.	2023-06-27 19:27:12 +00:00
Tom Kuson	a0a93a636f	Implement Pylint single-string-used-for-slots (C0205) as single-string-slots (PLC0205) (#5399) ... ## Summary Implement Pylint rule `single-string-used-for-slots` (`C0205`) as `single-string-slots` (`PLC0205`). This rule checks for single strings being assigned to `__slots__`. For example ```python class Foo: __slots__: str = "bar" def __init__(self, bar: str) -> None: self.bar = bar ``` should be ```python class Foo: __slots__: tuple[str, ...] = ("bar",) def __init__(self, bar: str) -> None: self.bar = bar ``` Related to #970. Includes documentation. ## Test Plan `cargo test`	2023-06-27 18:33:58 +00:00