8282 commits

This branch

This branch

All branches

Author	SHA1	Message	Date
Charlie Marsh	c6b82151dd	Add augmented assignment inference for -= operator (#13981) ... ## Summary See: https://github.com/astral-sh/ruff/issues/12699	2024-10-29 22:14:27 -04:00
Alex Waygood	39cf46ecd6	[red-knot] Improve ergonomics for the PySlice trait (#13983)	2024-10-29 20:40:59 +00:00
David Peter	96b3c400fe	[red-knot] Minor follow-up on slice expression inference (#13982) ... ## Summary Minor follow-up to #13917 — thanks @AlexWaygood for the post-merge review. - Add SliceLiteralType::as_tuple - Use .expect() instead of SAFETY comment - Match on ::try_from result - Add TODO comment regarding raising a diagnostic for `"foo"["bar":"baz"]`	2024-10-29 19:40:57 +00:00
jsurany	60a2dc53e7	fix issues in discovering ruff in pip build environments (#13881) ... ## Summary <!-- What's the purpose of the change? What does it do, and why? --> Changes in this PR https://github.com/astral-sh/ruff/pull/13591 did not allow correct discovery in pip build environments. ```python # both of these variables are tuple[str, str] (length is 2) first, second = os.path.split(paths[0]), os.path.split(paths[1]) # so these length checks are guaranteed to fail even for build environment folders if ( len(first) >= 3 and len(second) >= 3 ... ) ``` ~~Here we instead use `pathlib`, and we check all `pip-build-env-` paths for the folder that is expected to contain the `ruff` executable.~~ Here we update the logic to more properly split out the path components that we use for `pip-build-env-` inspection. ## Test Plan I've checked this manually against a workflow that was failing, I'm not sure what to do for real tests. The same issues apply as with the previous PR. --------- Co-authored-by: Jonathan Surany <jsurany@bloomberg.net> Co-authored-by: Charlie Marsh <charlie.r.marsh@gmail.com>	2024-10-29 15:50:29 +00:00
Alex Waygood	8d98aea6c4	[red-knot] Infer attribute expressions in type annotations (#13967)	2024-10-29 11:06:44 +00:00
Alex Waygood	d2c9f5e43c	[red-knot] Fallback to attributes on types.ModuleType if a symbol can't be found in locals or globals (#13904)	2024-10-29 10:59:03 +00:00
Alex Waygood	7dd0c7f4bd	[red-knot] Infer tuple types from annotations (#13943) ... ## Summary This PR adds support for heterogenous `tuple` annotations to red-knot. It does the following: - Extends `infer_type_expression` so that it understands tuple annotations - Changes `infer_type_expression` so that `ExprStarred` nodes in type annotations are inferred as `Todo` rather than `Unknown` (they're valid in PEP-646 tuple annotations) - Extends `Type::is_subtype_of` to understand when one heterogenous tuple type can be understood to be a subtype of another (without this change, the PR would have introduced new false-positive errors to some existing mdtests).	2024-10-29 10:30:03 +00:00
David Peter	56c796acee	[red-knot] Slice expression types & subscript expressions with slices (#13917) ... ## Summary - Add a new `Type::SliceLiteral` variant - Infer `SliceLiteral` types for slice expressions, such as `<int-literal>:<int-literal>:<int-literal>`. - Infer "sliced" literal types for subscript expressions using slices, such as `<string-literal>[<slice-literal>]`. - Infer types for expressions involving slices of tuples: `<tuple>[<slice-literal>]`. closes #13853 ## Test Plan - Unit tests for indexing/slicing utility functions - Markdown-based tests for - Subscript expressions `tuple[slice]` - Subscript expressions `string_literal[slice]` - Subscript expressions `bytes_literal[slice]`	2024-10-29 10:17:31 +01:00
Raphael Gaschignard	2fe203292a	[red-knot] Distribute intersections on negation (#13962) ... ## Summary This does two things: - distribute negated intersections when building up intersections (i.e. going from `A & ~(B & C)` to `(A & ~B) | (A & ~C)`) (fixing #13931) ## Test Plan `cargo test`	2024-10-29 02:56:04 +00:00
Charlie Marsh	b6847b371e	Skip namespace package enforcement for PEP 723 scripts (#13974) ... ## Summary Vendors the PEP 723 parser from [uv](debe67ffdb/crates/uv-scripts/src/lib.rs (L283)). Closes https://github.com/astral-sh/ruff/issues/13912.	2024-10-29 02:11:31 +00:00
Charlie Marsh	b19862c64a	Rename operator-unsupported to unsupported-operator (#13973) ... ## Summary Closes https://github.com/astral-sh/ruff/issues/13959.	2024-10-28 21:34:12 -04:00
TomerBin	9a0dade925	[red-knot] Type narrowing inside boolean expressions (#13970) ... ## Summary This PR adds type narrowing in `and` and `or` expressions, for example: ```py class A: ... x: A | None = A() if bool_instance() else None isinstance(x, A) or reveal_type(x) # revealed: None ``` ## Test Plan New mdtests 😍	2024-10-28 18:17:48 -07:00
Dhruv Manilawala	ec6208e51b	Treat return type of singledispatch as runtime-required (#13957) ... ## Summary fixes: #13955 ## Test Plan Update existing test case to use a return type hint for which `main` flags `TCH003`.	2024-10-28 20:33:28 -04:00
TomerBin	74cf66e4c2	[red-knot] Narrowing - Not operator (#13942) ... ## Summary After #13918 has landed, narrowing constraint negation became easy, so adding support for `not` operator. ## Test Plan Added a new mdtest file for `not` expression. --------- Co-authored-by: Carl Meyer <carl@astral.sh>	2024-10-28 20:27:26 +00:00
Carlo Lepelaars	1f19aca632	[DOCS] Add CrowdCent's numerblox to Ruff users. (#13569) ... Hi, our open source project [NumerBlox](https://github.com/crowdcent/numerblox) migrated to `uv` and `ruff`. Would appreciate the project being included in the list of Ruff users. ## Summary Add [NumerBlox](https://github.com/crowdcent/numerblox) to Ruff users in README.md.	2024-10-28 10:53:37 -04:00
Charlie Marsh	6f52d573ef	Support inference for PEP 604 union annotations (#13964) ... ## Summary Supports return type inference for, e.g., `def f() -> int | None:`. --------- Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>	2024-10-28 10:13:01 -04:00
Tim Hatch	c593ccb529	Regenerate known_stdlibs.rs with stdlibs 2024.10.25 (#13963) ... ## Summary `stdlibs` has a new release to properly categorize the `_wmi` module which has been [present since ~2022](https://github.com/python/cpython/issues/89545#issuecomment-1227846806). ## Test Plan Let CI run, this is only a trivial change to categorization data.	2024-10-28 08:37:54 -04:00
Micha Reiser	9f3a38d408	Extract LineIndex independent methods from Locator (#13938)	2024-10-28 07:53:41 +00:00
renovate[bot]	f8eb547fb4	Update dependency react-resizable-panels to v2.1.6 (#13952)	2024-10-28 07:02:12 +00:00
renovate[bot]	b77de359bc	Update NPM Development dependencies (#13954) ... Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>	2024-10-28 07:00:44 +00:00
renovate[bot]	41f74512df	Update Rust crate insta to v1.41.0 (#13956) ... Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Micha Reiser <micha@reiser.io>	2024-10-28 06:51:53 +00:00
renovate[bot]	387dc664bd	Update Rust crate thiserror to v1.0.65 (#13950)	2024-10-28 06:28:58 +00:00
renovate[bot]	41c9bdbd37	Update Rust crate syn to v2.0.85 (#13949)	2024-10-28 06:28:36 +00:00
renovate[bot]	222a646437	Update Rust crate serde to v1.0.213 (#13948)	2024-10-28 06:27:18 +00:00
renovate[bot]	5b411fe606	Update Rust crate proc-macro2 to v1.0.89 (#13946)	2024-10-28 06:26:53 +00:00
renovate[bot]	47dd83e56f	Update Rust crate regex to v1.11.1 (#13947)	2024-10-28 06:26:36 +00:00
renovate[bot]	08e23d78aa	Update Rust crate anyhow to v1.0.91 (#13945)	2024-10-28 06:25:44 +00:00
Dhruv Manilawala	5af0966057	Remove unreferenced snapshots (#13958)	2024-10-28 07:16:05 +01:00
renovate[bot]	faf9dfaa9d	Update dependency ruff to v0.7.1 (#13953)	2024-10-27 21:13:03 -04:00
renovate[bot]	9d131c8c45	Update dependency mdformat-mkdocs to v3.0.1 (#13951)	2024-10-27 21:12:55 -04:00
Micha Reiser	5a56886414	TCH003: Fix false positive for singledispatchmethod (#13941) ... ## Summary Fixes https://github.com/astral-sh/ruff/issues/13924 ## Test Plan Added test	2024-10-27 21:02:45 -04:00
TomerBin	66c3aaa307	[red-knot] - Flow-control for boolean operations (#13940) ... ## Summary As python uses short-circuiting boolean operations in runtime, we should mimic that logic in redknot as well. For example, we should detect that in the following code `x` might be undefined inside the block: ```py if flag or (x := 1): print(x) ``` ## Test Plan Added mdtest suit for boolean expressions. --------- Co-authored-by: Carl Meyer <carl@astral.sh>	2024-10-27 03:33:01 +00:00
cake-monotone	b6ffa51c16	[red-knot] Type inference for comparisons between arbitrary instances (#13903) ... Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com> Co-authored-by: Carl Meyer <carl@oddbird.net>	2024-10-26 18:19:56 +00:00
TomerBin	35f007f17f	[red-knot] Type narrow in else clause (#13918) ... ## Summary Add support for type narrowing in elif and else scopes as part of #13694. ## Test Plan - mdtest - builder unit test for union negation. --------- Co-authored-by: Carl Meyer <carl@astral.sh>	2024-10-26 16:22:57 +00:00
Jonas Vacek	3006d6da23	Docs: Add GitLab CI/CD to integrations. (#13915)	2024-10-26 18:10:17 +02:00
Micha Reiser	6aaf1d9446	[red-knot] Remove lint-phase (#13922) ... Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>	2024-10-25 18:40:52 +00:00
Alex Waygood	5eb87aa56e	[red-knot] Infer Todo, not Unknown, for PEP-604 unions in annotations (#13908)	2024-10-25 18:21:31 +00:00
David Peter	085a43a262	[red-knot] knot benchmark: fix --knot-path arg (#13923) ... ## Summary Previously, this would fail with ``` AttributeError: 'str' object has no attribute 'is_file' ``` if I tried to use the `--knot-path` option. I wish we had a type checker for Python*. ## Test Plan ```sh uv run benchmark --knot-path ~/.cargo-target/release/red_knot ``` \* to be fair, this would probably require special handling for `argparse` in the typechecker.	2024-10-25 11:43:39 +02:00
Micha Reiser	32b57b2ee4	Enable nursery rules: 'redundant_clone', 'debug_assert_with_mut_call', and 'unused_peekable' (#13920)	2024-10-25 09:46:30 +02:00
Dhruv Manilawala	337af836d3	Bump version to 0.7.1 (#13913)	2024-10-24 20:57:07 +05:30
Micha Reiser	113ce840a6	Fix normalize arguments when fstring_formatting is disabled (#13910)	2024-10-24 13:07:18 +00:00
Micha Reiser	7272f83868	Fix preview style name in can_omit_parentheses to is_f_string_formatting_enabled (#13907)	2024-10-24 11:32:28 +00:00
Alex Waygood	3eb454699a	[red-knot] Format mdtest Python snippets more concisely (#13905)	2024-10-24 11:09:31 +00:00
David Peter	77ae0ccf0f	[red-knot] Infer subscript expression types for bytes literals (#13901) ... ## Summary Infer subscript expression types for bytes literals: ```py b = b"\x00abc\xff" reveal_type(b[0]) # revealed: Literal[b"\x00"] reveal_type(b[1]) # revealed: Literal[b"a"] reveal_type(b[-1]) # revealed: Literal[b"\xff"] reveal_type(b[-2]) # revealed: Literal[b"c"] reveal_type(b[False]) # revealed: Literal[b"\x00"] reveal_type(b[True]) # revealed: Literal[b"a"] ``` part of #13689 (https://github.com/astral-sh/ruff/issues/13689#issuecomment-2404285064) ## Test Plan - New Markdown-based tests (see `mdtest/subscript/bytes.md`) - Added missing test for `string_literal[bool_literal]`	2024-10-24 12:07:41 +02:00
Micha Reiser	73ee72b665	Join implicit concatenated strings when they fit on a line (#13663)	2024-10-24 11:52:22 +02:00
Micha Reiser	e402e27a09	Use referencial equality in traversal helper methods (#13895)	2024-10-24 11:30:22 +02:00
Mihai Capotă	de4181d7dd	Remove "default" remark from ruff check (#13900) ... ## Summary `ruff check` has not been the default in a long time. However, the help message and code comment still designate it as the default. The remark should have been removed in the deprecation PR #10169. ## Test Plan Not tested.	2024-10-23 21:17:21 -04:00
David Peter	2c57c2dc8a	[red-knot] Type narrowing for isinstance checks (#13894) ... ## Summary Add type narrowing for `isinstance(object, classinfo)` [1] checks: ```py x = 1 if flag else "a" if isinstance(x, int): reveal_type(x) # revealed: Literal[1] ``` closes #13893 [1] https://docs.python.org/3/library/functions.html#isinstance ## Test Plan New Markdown-based tests in `narrow/isinstance.md`. --------- Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>	2024-10-23 20:51:33 +02:00
Micha Reiser	72c18c8225	Fix E221 and E222 to flag missing or extra whitespace around == operator (#13890)	2024-10-23 15:02:29 +02:00
Micha Reiser	00b078268b	Fix stale syntax errors in playground (#13888)	2024-10-23 12:30:10 +00:00