## Description
There is an issue with the quick fix list picker
This happens when list contains some incomplete or invalid items.
The fallback mechanism in the picker have 2 typos that trigger an error
trap
* The item line number field is item.lnum and not item.line
* A check is done on item.text twice in the same if condition, it should
to item.text and item.lnum
## Related Issue(s)
<!--
If this PR fixes any issues, please link to the issue here.
- Fixes #<issue_number>
-->
## Screenshots
<!-- Add screenshots of the changes if applicable. -->
## Description
<!-- Describe the big picture of your changes to communicate to the
maintainers
why we should accept this pull request. -->
Because the search item was lowercased before it was scored, camelCase
would not be triggered to give the intended bonus.
This was the simplest and fastest (code execution wise) fix I could see.
## Related Issue(s)
Fixes: https://github.com/folke/snacks.nvim/issues/1599
## Screenshots
<!-- Add screenshots of the changes if applicable. -->
## Description
Uses absolute path for setting the cursor
<!-- Describe the big picture of your changes to communicate to the
maintainers
why we should accept this pull request. -->
## Related Issue(s)
Fixes#1818
<!--
If this PR fixes any issues, please link to the issue here.
- Fixes #<issue_number>
-->
## Screenshots
<!-- Add screenshots of the changes if applicable. -->
---------
Co-authored-by: Aaron Weisberg <aaron.weisberg@quizlet.com>
## Description
Parsing the output of git diff here depends on its exact format. The
user environment might be set up with diff.noprefix, in which case the
parsing fails, because the `a/` and `b/` prefixes for the paths is
missing. Passing `-c diff.noprefix=false` to the call overrides this.
<!-- Describe the big picture of your changes to communicate to the
maintainers
why we should accept this pull request. -->
## Related Issue(s)
<!--
If this PR fixes any issues, please link to the issue here.
- Fixes #<issue_number>
-->
## Screenshots
<!-- Add screenshots of the changes if applicable. -->
## For people who want to use it NOW!
Use `init` to hack the latest version before this PR merge.
```lua
{
"folke/snacks.nvim",
init = function()
local sources = require("snacks.picker.config.sources")
sources.grep.toggles = {
regex = { value = true },
}
sources.grep.win = {
input = {
keys = {
["<a-r>"] = { "toggle_regex", mode = { "n", "i" }, desc = "Toggle Regex" },
},
},
}
end,
},
```
## Description
This PR adds a new keymap `<a-r>` for toggling the regex in grep picker.
It allows user to get faster when searching some special strings like
`$props()`, or just put a part of line `test to jump faster.
## Related Issue(s)
<!--
If this PR fixes any issues, please link to the issue here.
- Fixes #<issue_number>
-->
## Screenshots
https://github.com/user-attachments/assets/2442b21c-898f-4682-a966-5a82abdd23e8
---------
Co-authored-by: Folke Lemaitre <folke.lemaitre@gmail.com>
## Description
Before this fix, identical items are added to history repeatedly. This
PR fixes this by only adding an item to history if it's different from
the last recorded value.
This doesn't completely remove duplicate entries in the history, it only
prevents consecutive identical entries.
## Description
- I was trying to go to the commit page from fugitive commit buffers
- but snacks.nvim doesn't support this (fugitive does) and so I wanted a
way to send the commit IDs to the gitbrowse function after parsing it
myself in my dotfiles
### changes
- added `commit` option to `gitbrowse` config to allow passing commit
hashes directly instead of only auto-detecting from cursor word or file
history
- only falls back to auto-detection when `commit` is not explicitly
provided
## Related Issue(s)
<!--
If this PR fixes any issues, please link to the issue here.
- Fixes #<issue_number>
-->
## Screenshots
<!-- Add screenshots of the changes if applicable. -->
## Description
the documentation for `snacks.notifier.Config` says:
f6c06415a2/lua/snacks/notifier.lua (L120-L122)
But currently all notifications filtered out by either `opts.level` or
`opts.filter` are also omitted from the history, on top of being
suppressed from displaying
Fixes this regression
## Related Issue(s)
* Related to #93, although that was caused by misconfiguration. This one
is an actual bug
* Closes#2208
## Screenshots
n/a
## Description
When opening a terminal with position='current', the terminal buffer
wasn't being set in the current window, causing the original buffer
content to remain visible with terminal styling applied.
This fix adds a call to vim.api.nvim_win_set_buf() to properly set the
terminal buffer when using position='current'. Also updates type
annotations to include the 'current' position option and adds tests to
prevent regression.
Credit to the solution to by @Baricus in issue #2148.
## Related Issue(s)
Fixes#2148
Co-authored-by: Baricus <31926270+Baricus@users.noreply.github.com>
## Description
GitLab highlighting uses a different scheme for range of lines
fb2f3ce787/app/assets/javascripts/repository/mixins/highlight_mixin.js (L114)
## Related Issue(s)
<!--
If this PR fixes any issues, please link to the issue here.
- Fixes #<issue_number>
-->
## Screenshots
<!-- Add screenshots of the changes if applicable. -->
## Description
This PR fixes an issue where normal mode commands were being executed in
terminal mode buffers. The change ensures that the command `norm! zz` is
only executed if the buffer type is not "terminal". This prevents errors
when using Zen mode with terminal buffers.
## Related Issue(s)
- Fixes#1911
## Screenshots
<!-- Add screenshots of the changes if applicable. -->
## Description
Fix typo in snacks-picker docs. I've noticed the docs are
auto-generated, so I split my changes into 2 commits so I can drop the
change to the markdown file if preferred. Just let me know!
---------
Co-authored-by: Folke Lemaitre <folke.lemaitre@gmail.com>
## Description
Allow specifying a page number for pdfs inside of markdown.
This is done by adding "#page=<page-number>" to the file name. This is
same way it is done in obsidian (as discussed in
https://forum.obsidian.md/t/link-to-the-exact-page-of-and-external-pdf-file/2111)
The parsing of the page info should probably be done way before the
conversion, but this was the best I could with my limited time.
I'm pretty new to lua, and this codebase, so this might not be the best
code, but I hope it at least helps :D
## Related Issue(s)
- Fixes#1805
Fix off-by-one issue in render_fallback when a tabline is shown (e.g.
with plugins like bufferline.nvim).
## Description
When a tabline is used/shown, the positioning in render_fallback is off
by one. This change checks whether a tabline would be shown and uses the
correct math for that case and, otherwise, works as before.
## Related Issue(s)
- Fixes#1557
## Description
<!-- Describe the big picture of your changes to communicate to the
maintainers
why we should accept this pull request. -->
This fixes the `image.src` capture for markdown shortcut links, which
(imho) are links like `![[attachments/test.jpg]]`.
The current query captures also the `[...]`.
If we talk about a different type of links for this query, it would be
interesting to know which ones :).
## Related Issue(s)
<!--
If this PR fixes any issues, please link to the issue here.
- Fixes #<issue_number>
-->
## Screenshots
<!-- Add screenshots of the changes if applicable. -->
## Description
This PR adds basic support for visual block selections to
`Snacks.debug.run()`. This is useful when code doesn't start at the
beginning of a line, such as in comment blocks.
## Related Issue(s)
<!--
If this PR fixes any issues, please link to the issue here.
- Fixes #<issue_number>
-->
## Screenshots
<!-- Add screenshots of the changes if applicable. -->
<img width="271" alt="Screenshot 2025-02-19 at 23 02 35"
src="https://github.com/user-attachments/assets/5a440b32-6846-4345-b105-42e64796ac65"
/>
